feat: added assert/is-negative-finite

[gunjjoshi]

This commit adds the assert/is-negative-finite module for handling negative finite values.

Resolves #1345 .

Description

What is the purpose of this pull request?

Adds the package @stdlib/assert/is-negative-finite.

Related Issues

Does this pull request have any related issues?

Yes, it resolves #1345

This pull request:

• resolves [RFC]: add @stdlib/assert/is-negative-finite #1345

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Test Logs:

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• ☑️ Read, understood, and followed the contributing guidelines.

---

@stdlib-js/reviewers

[stdlib-bot]

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

[Pranavchiku]

I think we need to import is-finite just like var isNumber

[Pranavchiku]

cc @gunjjoshi

--- a/lib/node_modules/@stdlib/assert/is-negative-finite/lib/object.js
+++ b/lib/node_modules/@stdlib/assert/is-negative-finite/lib/object.js
@@ -21,6 +21,7 @@
 // MODULES //
 
 var isNumber = require( '@stdlib/assert/is-number' ).isObject;
+var isFinite = require( '@stdlib/assert/is-finite' ).isObject;
 
 
 // MAIN //
diff --git a/lib/node_modules/@stdlib/assert/is-negative-finite/lib/primitive.js b/lib/node_modules/@stdlib/assert/is-negative-finite/lib/primitive.js
index 02f04272b8..6e40cf290d 100644
--- a/lib/node_modules/@stdlib/assert/is-negative-finite/lib/primitive.js
+++ b/lib/node_modules/@stdlib/assert/is-negative-finite/lib/primitive.js
@@ -21,6 +21,7 @@
 // MODULES //
 
 var isNumber = require( '@stdlib/assert/is-number' ).isPrimitive;
+var isFinite = require( '@stdlib/assert/is-finite' ).isPrimitive;
 
 
 // MAIN //

[Pranavchiku]

I see here is the error:

make[1]: Entering directory '/Users/pranavchiku/repos/stdlib-js/stdlib'

Linting file: lib/node_modules/@stdlib/assert/is-negative-finite/lib/object.js

/Users/pranavchiku/repos/stdlib-js/stdlib/lib/node_modules/@stdlib/assert/is-negative-finite/lib/object.js
  24:5  error  isFinite is already defined  stdlib/no-redeclare

✖ 1 problem (1 error, 0 warnings)

make[1]: *** [/Users/pranavchiku/repos/stdlib-js/stdlib/tools/make/lib/lint/javascript/eslint.mk:225: eslint-files] Error 1
make[1]: Leaving directory '/Users/pranavchiku/repos/stdlib-js/stdlib'
make: *** [/Users/pranavchiku/repos/stdlib-js/stdlib/tools/make/lib/lint/javascript/Makefile:158: lint-javascript-files] Error 2

JavaScript lint errors for source files.

To fix this use the following diff

--- a/lib/node_modules/@stdlib/assert/is-negative-finite/lib/object.js
+++ b/lib/node_modules/@stdlib/assert/is-negative-finite/lib/object.js
@@ -21,6 +21,7 @@
 // MODULES //
 
 var isNumber = require( '@stdlib/assert/is-number' ).isObject;
+var isFinite = require( '@stdlib/assert/is-finite' ).isObject; // eslint-disable-line stdlib/no-redeclare
 
 
 // MAIN //
diff --git a/lib/node_modules/@stdlib/assert/is-negative-finite/lib/primitive.js b/lib/node_modules/@stdlib/assert/is-negative-finite/lib/primitive.js
index 02f04272b8..e7356daee4 100644
--- a/lib/node_modules/@stdlib/assert/is-negative-finite/lib/primitive.js
+++ b/lib/node_modules/@stdlib/assert/is-negative-finite/lib/primitive.js
@@ -21,6 +21,7 @@
 // MODULES //
 
 var isNumber = require( '@stdlib/assert/is-number' ).isPrimitive;
+var isFinite = require( '@stdlib/assert/is-finite' ).isPrimitive; // eslint-disable-line stdlib/no-redeclare

[Planeshifter]

This should be close to being able to get merged, thanks for your contribution!

As @Pranavchiku mentioned, we should explicitly require @stdlib/assert/is-finite.

[gunjjoshi]

Thanks for your suggestions @Planeshifter @Pranavchiku, I have made the suggested changes.

[Planeshifter]

@gunjjoshi CI has passed; will give it one more review and then merge. Thanks for your contribution!