Skip to content

[RFC]: add @stdlib/array/base/join #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
kgryte opened this issue Feb 21, 2024 · 3 comments · Fixed by #1463
Closed
3 tasks done

[RFC]: add @stdlib/array/base/join #1327

kgryte opened this issue Feb 21, 2024 · 3 comments · Fixed by #1463
Assignees
@prasad-1803
Labels
Accepted RFC feature request which has been accepted. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. priority: Low Low priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Utilities Issue or pull request concerning general utilities.

Comments

@kgryte
Copy link
Member

kgryte commented Feb 21, 2024

Description

This RFC proposes adding the package @stdlib/array/base/join.

The package should have a structure similar to @stdlib/array/base/slice and should similarly check for the existence of a join method. If not present, the function should manually construct the output string and similarly treat null and undefined as an empty string (see MDN).

function join( x, separator ) {...}

The separator argument should be required.

Package: @stdlib/array/base/join
Alias: join.

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@kgryte kgryte added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! labels Feb 21, 2024
@prasad-1803
Copy link

hey ! @kgryte i want to work on this issue , can you please assign this to me.

@kgryte
Copy link
Member Author

kgryte commented Feb 22, 2024

Thanks for volunteering to work on this, @prasad-1803. Please feel free to submit a PR implementing this feature.

@kgryte kgryte added priority: Low Low priority concern or feature request. Utilities Issue or pull request concerning general utilities. Accepted RFC feature request which has been accepted. JavaScript Issue involves or relates to JavaScript. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. labels Feb 23, 2024
@adityacodes30
Copy link
Contributor

adityacodes30 commented Feb 29, 2024 •
edited
Loading

It has been a while @prasad-1803, if you're not working on this one perhaps i could take it up ?

adityacodes30 added a commit to adityacodes30/stdlib that referenced this issue Mar 3, 2024
@adityacodes30
feat(array/base): add join function
3d60550 
In progress on issue stdlib-js#1327.
adityacodes30 added a commit to adityacodes30/stdlib that referenced this issue Mar 3, 2024
@adityacodes30
feat(array/base): add join function
7dd294b 
closes stdlib-js#1327.
@adityacodes30 adityacodes30 mentioned this issue Mar 3, 2024
Merged
1 task
Planeshifter added a commit that referenced this issue Mar 5, 2024
@adityacodes30 @kgryte @Planeshifter
feat: add array/base/join
bb7817f 
PR-URL: #1463
Closes: #1327

---------

Signed-off-by: Athan Reines <[email protected]>
Signed-off-by: Aditya Sapra <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
bad-in-coding pushed a commit to bad-in-coding/stdlib that referenced this issue Mar 7, 2024
@adityacodes30 @kgryte @Planeshifter
feat: add array/base/join
a5fb268 
PR-URL: stdlib-js#1463
Closes: stdlib-js#1327

---------

Signed-off-by: Athan Reines <[email protected]>
Signed-off-by: Aditya Sapra <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prasad-1803 prasad-1803

Labels
Accepted RFC feature request which has been accepted. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. priority: Low Low priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add array/base/join adityacodes30/stdlib
3 participants
@kgryte @adityacodes30 @prasad-1803