Skip to content

[RFC]: Add C implementation for @stdlib/math/base/special/log #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
aman-095 opened this issue Mar 2, 2024 · 2 comments · Fixed by #1454
Closed
3 tasks done

[RFC]: Add C implementation for @stdlib/math/base/special/log #1453

aman-095 opened this issue Mar 2, 2024 · 2 comments · Fixed by #1454
Labels
C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.

Comments

@aman-095
Copy link
Member

aman-095 commented Mar 2, 2024

Description

This RFC proposes adding native C implementation for @stdlib/math/base/special/log

double stdlib_base_log( const double x, const double b );

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@aman-095
Copy link
Member Author

aman-095 commented Mar 2, 2024

I have PR ready for the issue and will push in a while.

@aman-095 aman-095 mentioned this issue Mar 2, 2024
Merged
1 task
@Pranavchiku
Copy link
Member

Thanks for volunteering!

@Pranavchiku Pranavchiku added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. Good First Issue A good first issue for new contributors! priority: Normal Normal priority concern or feature request. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. labels Mar 3, 2024
Planeshifter pushed a commit that referenced this issue Mar 3, 2024
@aman-095 @Pranavchiku
feat: add C implementation for math/base/special/log
c86db95 
PR-URL: #1454 
Closes: #1453

---------

Signed-off-by: Pranav <[email protected]>
Co-authored-by: Pranav <[email protected]>
Reviewed-by: Pranav <[email protected]>
bad-in-coding pushed a commit to bad-in-coding/stdlib that referenced this issue Mar 7, 2024
@aman-095 @Pranavchiku
feat: add C implementation for math/base/special/log
ef37a9f 
PR-URL: stdlib-js#1454 
Closes: stdlib-js#1453

---------

Signed-off-by: Pranav <[email protected]>
Co-authored-by: Pranav <[email protected]>
Reviewed-by: Pranav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add C implementation for @stdlib/math/base/special/log aman-095/stdlib
2 participants
@Pranavchiku @aman-095