Skip to content

[RFC]: refactor blas/ext/base/sapx to follow current project conventions #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
Planeshifter opened this issue Mar 3, 2024 · 3 comments · Fixed by #1824
Closed
3 tasks done

[RFC]: refactor blas/ext/base/sapx to follow current project conventions #1509

Planeshifter opened this issue Mar 3, 2024 · 3 comments · Fixed by #1824
Labels
Accepted RFC feature request which has been accepted. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.

Comments

@Planeshifter
Copy link
Member

Description

This RFC proposes refactoring @stdlib/blas/ext/base/sapx to follow current project conventions.

These conventions are outlined in more detail in #788. Namely, we want to migrate from C++ add-on interfaces to C add-on interfaces and then make various style and simplification changes.

Some example commits which perform most, if not all, of the requested changes include d66d80c (saxpy), 3c82fe7 (cswap), and 5b15c96 (dasum).

Related Issues

Related issues #788, #1152.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Planeshifter Planeshifter added Good First Issue A good first issue for new contributors! Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. JavaScript Issue involves or relates to JavaScript. labels Mar 3, 2024
@AuenKr
Copy link
Contributor

AuenKr commented Mar 5, 2024

Hey @Planeshifter, I would like to work on this issue.
Can you assign me?

@Planeshifter
Copy link
Member Author

@AuenKr Done!

@AuenKr
Copy link
Contributor

AuenKr commented Mar 13, 2024

sorry for delay as I am working on diffrent issue #1322, as @rxbryan has already done PR /pull/1824.
@Planeshifter you can reassign this issue to @rxbryan.

@AuenKr AuenKr removed their assignment Mar 13, 2024
@rxbryan rxbryan mentioned this issue Mar 14, 2024
Merged
1 task
@kgryte kgryte added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. RFC Request for comments. Feature requests and proposed changes. Accepted RFC feature request which has been accepted. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. labels Mar 20, 2024
kgryte added a commit that referenced this issue Mar 21, 2024
@rxbryan @kgryte
refactor: update blas/ext/base/sapx to follow current project conve…
e4f0dcd 
…ntions

PR-URL: 	#1824
Closes: #1509
Ref: #1152
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted RFC feature request which has been accepted. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: update blas/ext/base/sapx to follow current project conventions rxbryan/stdlib
3 participants
@Planeshifter @kgryte @AuenKr