Skip to content

[RFC]: refactor blas/ext/base/ssum to follow current project conventions #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
Planeshifter opened this issue Mar 3, 2024 · 4 comments · Fixed by #1802
Closed
3 tasks done

[RFC]: refactor blas/ext/base/ssum to follow current project conventions #1540

Planeshifter opened this issue Mar 3, 2024 · 4 comments · Fixed by #1802
Assignees
@raunak-dev-edu
Labels
Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request.

Comments

@Planeshifter
Copy link
Member

Description

This RFC proposes refactoring @stdlib/blas/ext/base/ssum to follow current project conventions.

These conventions are outlined in more detail in #788. Namely, we want to migrate from C++ add-on interfaces to C add-on interfaces and then make various style and simplification changes.

Some example commits which perform most, if not all, of the requested changes include d66d80c (saxpy), 3c82fe7 (cswap), and 5b15c96 (dasum).

Related Issues

Related issues #788, #1152.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Planeshifter Planeshifter added Good First Issue A good first issue for new contributors! Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. JavaScript Issue involves or relates to JavaScript. labels Mar 3, 2024
@raunak-dev-edu
Copy link
Contributor

Hey @Planeshifter, I would Like to work upon this issue. Please assign it to me.

@raunak-dev-edu
Copy link
Contributor

@Planeshifter , Please assign this issue to me. I want to work on this issue.

@Planeshifter
Copy link
Member Author

@raunak-dev-edu Done. Thanks for taking this on!

@raunak-dev-edu raunak-dev-edu mentioned this issue Mar 9, 2024
Merged
1 task
@dagmfre
Copy link

dagmfre commented Apr 1, 2024

Does this issue require C or C++ skill?

Planeshifter added a commit that referenced this issue Apr 20, 2024
@raunak-dev-edu @Pranavchiku @Planeshifter
refactor: update blas/ext/base/ssum to follow current project conve…
8d66a07 
…ntions

PR-URL: #1802 
Closes: #1540
Ref: #1152 

---------

Signed-off-by: Raunak Kumar Gupta <[email protected]>
Co-authored-by:  Pranav Goswami <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Pranav Goswami <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raunak-dev-edu raunak-dev-edu

Labels
Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: update blas/ext/base/ssum to follow current project convent… raunak-dev-edu/stdlib
3 participants
@Planeshifter @raunak-dev-edu @dagmfre