Skip to content

[RFC]: add @stdlib/string/base/last-grapheme-cluster #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
adityacodes30 opened this issue Mar 6, 2024 · 4 comments · Fixed by #1810
Closed
3 tasks done

[RFC]: add @stdlib/string/base/last-grapheme-cluster #1729

adityacodes30 opened this issue Mar 6, 2024 · 4 comments · Fixed by #1810
Assignees
@adityacodes30
Labels
Accepted RFC feature request which has been accepted. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Utilities Issue or pull request concerning general utilities.

Comments

@adityacodes30
Copy link
Contributor

adityacodes30 commented Mar 6, 2024 •
edited
Loading

Description

This RFC proposes adding the package @stdlib/string/base/last-grapheme-cluster which will return the last n grapheme clusters ( user-perceived characters ) of a string.

signature
lastGraphemeCluster( string, n )

Package: @stdlib/string/base/last-grapheme-cluster
Alias: lastGraphemeCluster

This will help with development of @stdlib/string/last

Related Issues

Related issues #854

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@adityacodes30
Copy link
Contributor Author

adityacodes30 commented Mar 6, 2024 •
edited
Loading

i would like to work on this, once related pr(s) are merged

@gawandeabhishek gawandeabhishek mentioned this issue Mar 6, 2024
Closed
1 task
@Planeshifter
Copy link
Member

@adityacodes30 Notice that this should be grapheme instead of graphene.

@adityacodes30
Copy link
Contributor Author

misread it, apologies, will edit could you please add the appropriate labels and assign it to me. Thank you

@adityacodes30 adityacodes30 changed the title [RFC]: add @stdlib/string/base/last-graphene-cluster [RFC]: add @stdlib/string/base/last-grapheme-cluster Mar 6, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities. Good First Issue A good first issue for new contributors! priority: Normal Normal priority concern or feature request. JavaScript Issue involves or relates to JavaScript. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Accepted RFC feature request which has been accepted. RFC Request for comments. Feature requests and proposed changes. labels Mar 6, 2024
@kgryte
Copy link
Member

kgryte commented Mar 6, 2024

@adityacodes30 I've reviewed, added labels, and assigned you.

adityacodes30 added a commit to adityacodes30/stdlib that referenced this issue Mar 9, 2024
@adityacodes30
feat: add last-grapheme-cluster stdlib-js#1729
36cecd7
@adityacodes30 adityacodes30 mentioned this issue Mar 9, 2024
Merged
1 task
kgryte added a commit that referenced this issue Mar 21, 2024
@adityacodes30 @kgryte
feat: add string/base/last-grapheme-cluster
bbc3cfc 
PR-URL: 	#1810
Closes: #1729
Ref: #854
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adityacodes30 adityacodes30

Labels
Accepted RFC feature request which has been accepted. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
3 participants
@Planeshifter @kgryte @adityacodes30