Skip to content

Insufficient TypeScript declaration tests for @stdlib/utils/circular-buffer #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
2 tasks done
kgryte opened this issue Jan 12, 2022 · 3 comments
Open
2 tasks done

Insufficient TypeScript declaration tests for @stdlib/utils/circular-buffer #474

kgryte opened this issue Jan 12, 2022 · 3 comments
Labels
Bug Something isn't working. Good First Issue A good first issue for new contributors! TypeScript Issue involves or relates to TypeScript.

Comments

@kgryte
Copy link
Member

kgryte commented Jan 12, 2022

Description

Upon inspection of the TypeScript declaration tests for @stdlib/utils/circular-buffer, I noticed that the current tests do not cover the entire API.

These tests should be expanded to cover the entire API surface to ensure that the current definitions are correct.

Related Issues

None.

Questions

No.

Demo

No response

Reproduction

N/A

Expected Results

N/A

Actual Results

n/A

Version

No response

Environments

N/A

Browser Version

No response

Node.js / npm Version

No response

Platform

No response

Checklist

  • Read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
@kgryte kgryte added Bug Something isn't working. Good First Issue A good first issue for new contributors! TypeScript Issue involves or relates to TypeScript. labels Jan 12, 2022
@mohamadaminkarami mohamadaminkarami mentioned this issue Feb 4, 2022
Closed
1 task
@mohamadaminkarami
Copy link

Hi, Please check my pull request.

@skoriop skoriop mentioned this issue Feb 28, 2024
Merged
1 task
@rajutkarsh07
Copy link
Contributor

@kgryte @Planeshifter I have understood this issue. I can solve this, please assign this issue to me

@Planeshifter
Copy link
Member

@rajutkarsh07 Assigned you to work on #859, so please finish that first before putting more on your plate.

Ayansaxena24 added a commit to Ayansaxena24/stdlib that referenced this issue Apr 1, 2024
@Ayansaxena24
Update test.ts
3535328 
Updating test.ts by adding few additional tests for the issue --> Insufficient TypeScript declaration tests for @stdlib/utils/circular-buffer stdlib-js#474
This was referenced Apr 1, 2024
Closed
Closed
Planeshifter added a commit that referenced this issue Sep 7, 2024
@skoriop @Planeshifter @kgryte
test: add tests to utils/circular-buffer
8edb71d 
PR-URL: #1403
Ref: #474

---------

Signed-off-by: Philipp Burckhardt <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working. Good First Issue A good first issue for new contributors! TypeScript Issue involves or relates to TypeScript.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: implement circularBuffer type checks
Update test.ts Ayansaxena24/stdlib
4 participants
@Planeshifter @kgryte @rajutkarsh07 @mohamadaminkarami