Skip to content

[BUG]: Eager Evaluation Misbehaves on Call Expressions with Member Access (tutorial().anything) #5045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
Vinit-Pandit opened this issue Feb 3, 2025 · 1 comment · Fixed by #5046
Closed
2 tasks done

[BUG]: Eager Evaluation Misbehaves on Call Expressions with Member Access (tutorial().anything) #5045

Vinit-Pandit opened this issue Feb 3, 2025 · 1 comment · Fixed by #5046
Labels
Bug Something isn't working. REPL Issue or pull request specific to the project REPL.

Comments

@Vinit-Pandit
Copy link
Contributor

Description

Actually, this is my mistake. In the current logic, I am directly returning true in traverse for MemberExpression but it actually requires further checks.

Image

Related Issues

Related issues #2073

Questions

No.

Demo

No response

Reproduction

in repl type `tutorial().something`

Expected Results

Eager evaluation on `MemberExpression` code require check

Actual Results

See the image above for reference.

Version

No response

Environments

Node.js

Browser Version

No response

Node.js / npm Version

No response

Platform

No response

Checklist

  • Read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first issue! We will get back to you shortly. 🏃 💨

@Vinit-Pandit Vinit-Pandit mentioned this issue Feb 3, 2025
Merged
1 task
@kgryte kgryte closed this as completed in 079b5ac Feb 4, 2025
@kgryte kgryte added Bug Something isn't working. REPL Issue or pull request specific to the project REPL. labels Feb 4, 2025
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this issue Feb 11, 2025
@Vinit-Pandit @saurabhraghuvanshii
fix: add MemberExpression check
6f47ad7 
PR-URL: stdlib-js#5046
Closes: stdlib-js#5045
Reviewed-by: Athan Reines <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this issue Feb 26, 2025
@Vinit-Pandit @ShabiShett07
fix: add MemberExpression check
0acf4c9 
PR-URL: stdlib-js#5046
Closes: stdlib-js#5045
Reviewed-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working. REPL Issue or pull request specific to the project REPL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add MemberExpression check Vinit-Pandit/stdlibMine
3 participants
@kgryte @stdlib-bot @Vinit-Pandit