Skip to content

[RFC]: Add C implementation for @stdlib/math/base/special/ellipe #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
Pranavchiku opened this issue Dec 24, 2022 · 7 comments · Fixed by #1452
Closed
3 tasks done

[RFC]: Add C implementation for @stdlib/math/base/special/ellipe #772

Pranavchiku opened this issue Dec 24, 2022 · 7 comments · Fixed by #1452
Assignees
@gunjjoshi
Labels
Accepted RFC feature request which has been accepted. Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. RFC Request for comments. Feature requests and proposed changes.

Comments

@Pranavchiku
Copy link
Member

Description

This RFC proposes adding C implementation for @stdlib/math/base/special/ellipe.

double stdlib_base_ellipe( const double m );

Related Issues

#766.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Pranavchiku Pranavchiku added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. labels Dec 24, 2022
@Pranavchiku Pranavchiku self-assigned this Dec 24, 2022
@Pranavchiku Pranavchiku added Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. and removed Feature Issue or pull request for adding a new feature. labels Dec 24, 2022
@Pranavchiku Pranavchiku mentioned this issue Dec 24, 2022
Open
@Pranavchiku Pranavchiku removed their assignment Jan 17, 2023
@gunjjoshi
Copy link
Member

Hey, can I get assigned for this issue ? @Pranavchiku

@kgryte
Copy link
Member

kgryte commented Mar 1, 2024

@gunjjoshi Sounds good. Feel free to submit a PR adding the implementation.

@gunjjoshi
Copy link
Member

Hey @kgryte , upon trying to commit the changes, I get a console message saying that cppcheck is not installed. Even though after installing it using brew install cppcheck, it says the same thing. Do you have any ideas regarding this ?

Screenshot 2024-03-02 at 01 40 23

@gunjjoshi
Copy link
Member

Also, after installing it, all the files in /lib such as poly_p1.js, poly_p2.js, poly_p3.js.... change automatically.
Thus resulting in lint errors arising due to different expected values.

@kgryte
Copy link
Member

kgryte commented Mar 2, 2024

Run make install-deps-cppcheck

@kgryte
Copy link
Member

kgryte commented Mar 2, 2024

Also, not sure why the files in /lib would change automatically. cppcheck is only for linting. It is not a runtime C or JS dep.

@Pranavchiku Pranavchiku mentioned this issue Mar 2, 2024
Closed
3 tasks
@gunjjoshi
Copy link
Member

Also, not sure why the files in /lib would change automatically. cppcheck is only for linting. It is not a runtime C or JS dep.

Thanks, I'll check if something is wrong on my side once again.

@gunjjoshi gunjjoshi mentioned this issue Mar 2, 2024
Merged
kgryte added a commit that referenced this issue Mar 6, 2024
@gunjjoshi @kgryte @Pranavchiku
feat: add C implementation for math/base/special/ellipe
23f2db6 
Closes: #772
PR-URL: 	#1452
Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Pranav Goswami <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Pranav Goswami <[email protected]>
Signed-off-by: GUNJ JOSHI <[email protected]>
Signed-off-by: Pranav Goswami <[email protected]>
@kgryte kgryte added the Accepted RFC feature request which has been accepted. label Mar 6, 2024
bad-in-coding pushed a commit to bad-in-coding/stdlib that referenced this issue Mar 7, 2024
@gunjjoshi @kgryte @Pranavchiku
feat: add C implementation for math/base/special/ellipe
54d4493 
Closes: stdlib-js#772
PR-URL: 	stdlib-js#1452
Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Pranav Goswami <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Pranav Goswami <[email protected]>
Signed-off-by: GUNJ JOSHI <[email protected]>
Signed-off-by: Pranav Goswami <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gunjjoshi gunjjoshi

Labels
Accepted RFC feature request which has been accepted. Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. RFC Request for comments. Feature requests and proposed changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add C implementation for math/base/special/ellipe
3 participants
@kgryte @gunjjoshi @Pranavchiku