Skip to content

[RFC]: Add @stdlib/string/base/replace-before-last #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
kgryte opened this issue Feb 1, 2023 · 3 comments · Fixed by #1364
Closed
3 tasks done

[RFC]: Add @stdlib/string/base/replace-before-last #813

kgryte opened this issue Feb 1, 2023 · 3 comments · Fixed by #1364
Assignees
@AuenKr
Labels
Accepted RFC feature request which has been accepted. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. priority: Low Low priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Utilities Issue or pull request concerning general utilities.

Comments

@kgryte
Copy link
Member

kgryte commented Feb 1, 2023

Description

This RFC proposes adding a utility to replace the substring before the last occurrence of a specified search string.

Similar to other base string APIs, the package should assume valid inputs.

Logic should be similar to @stdlib/string/substring-before-last.

Package: @stdlib/string/base/replace-before-last
Alias: replaceBeforeLast

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@kgryte kgryte added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! labels Feb 1, 2023
@varunsh17
Copy link

I have read and understood the requirements needed for this issue.
Can I be assigned so that I can start working immediately?
Thanks

@AuenKr
Copy link
Contributor

AuenKr commented Feb 23, 2024

I have almost completed replace-after and replace-after-last issue which is very similar to this issue, can i get assign for this issue?

@AuenKr AuenKr mentioned this issue Feb 24, 2024
Merged
1 task
@kgryte
Copy link
Member Author

kgryte commented Feb 24, 2024

Looks like @AuenKr has already submitted a PR for this, so will assign accordingly.

@kgryte kgryte added priority: Low Low priority concern or feature request. Accepted RFC feature request which has been accepted. JavaScript Issue involves or relates to JavaScript. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Utilities Issue or pull request concerning general utilities. labels Feb 24, 2024
Planeshifter added a commit that referenced this issue Feb 27, 2024
@AuenKr @stdlib-bot
@kgryte @Planeshifter
feat: add string/base/replace-before-last
272f91b 
PR-URL: #1364
Closes: #813

Signed-off-by: Athan Reines <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AuenKr AuenKr

Labels
Accepted RFC feature request which has been accepted. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. priority: Low Low priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add string/base/replace-before-last
3 participants
@kgryte @varunsh17 @AuenKr