Skip to content

[RFC]: Add @stdlib/napi/argv-complex128 #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
kgryte opened this issue Feb 1, 2023 · 5 comments · Fixed by #1745
Closed
3 tasks done

[RFC]: Add @stdlib/napi/argv-complex128 #816

kgryte opened this issue Feb 1, 2023 · 5 comments · Fixed by #1745
Assignees
@bad-in-coding
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! Native Addons Issue involves or relates to Node.js native add-ons. RFC Request for comments. Feature requests and proposed changes. Utilities Issue or pull request concerning general utilities.

Comments

@kgryte
Copy link
Member

kgryte commented Feb 1, 2023

Description

This RFC proposes adding C APIs for converting a JavaScript Complex128 object instance to a native C data type stdlib_complex128_t. Should be similar to other @stdlib/napi/argv-* APIs.

Package: @stdlib/napi/argv-complex128

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@kgryte kgryte added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. Native Addons Issue involves or relates to Node.js native add-ons. Good First Issue A good first issue for new contributors! labels Feb 1, 2023
@AuenKr
Copy link
Contributor

AuenKr commented Feb 24, 2024

Hey @kgryte, I would like to work on this issue, could you assign this to me?

@kgryte
Copy link
Member Author

kgryte commented Feb 24, 2024

@AuenKr I believe you are already working on issues. It is better to get those over the finish and the PRs merged than move on to other things.

@AuenKr
Copy link
Contributor

AuenKr commented Feb 24, 2024

@AuenKr I believe you are already working on issues. It is better to get those over the finish and the PRs merged than move on to other things.

I have finish those task(issue#812, 813, 814 all are similar) and open PR.
Can I work on this issue or wait for PR to merge? @kgryte

@kgryte
Copy link
Member Author

kgryte commented Feb 24, 2024 •
edited
Loading

@AuenKr I left some comments on #812, and there are changes that need to be made, so let's get those over the finish line first.

@kgryte kgryte added Utilities Issue or pull request concerning general utilities. Accepted RFC feature request which has been accepted. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. C Issue involves or relates to C. labels Feb 24, 2024
@bad-in-coding bad-in-coding mentioned this issue Mar 2, 2024
Closed
1 task
@bad-in-coding
Copy link
Contributor

Hi @kgryte , I worked on this issue. Can you please review it and let me know the changes required. Thanks!

@bad-in-coding bad-in-coding mentioned this issue Mar 7, 2024
Merged
1 task
kgryte added a commit that referenced this issue Apr 17, 2024
@bad-in-coding @kgryte
feat: add napi/argv-complex128
ced016b 
PR-URL: #1745
Closes: #816
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Co-authored-by: Utkarsh Gupta <[email protected]>
Co-authored-by: Utkarsh Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bad-in-coding bad-in-coding

Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! Native Addons Issue involves or relates to Node.js native add-ons. RFC Request for comments. Feature requests and proposed changes. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
3 participants
@kgryte @AuenKr @bad-in-coding