Skip to content

feat: add array/empty-like #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 7, 2023
Merged

feat: add array/empty-like #1041

merged 8 commits into from
Jul 7, 2023

Conversation

steff456
Copy link
Contributor

This is a continuation of the work done in #983

Description

What is the purpose of this pull request?

This pull request:

  • Adds the array/empty-like package

Related Issues

Does this pull request have any related issues?

No

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@steff456 steff456 added the Feature Issue or pull request for adding a new feature. label Jun 24, 2023
@steff456 steff456 requested review from Planeshifter and kgryte June 24, 2023 05:38
@steff456 steff456 self-assigned this Jun 24, 2023
kgryte
kgryte requested changes Jun 28, 2023
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steff456 Thanks for submitting this PR. In general, the implementation works; we just need to some clean-up before we can merge. Once the comments are addressed, we can move this PR forward. Thanks!

@kgryte kgryte merged commit 81b8f6c into develop Jul 7, 2023
@kgryte kgryte deleted the empty-like branch July 7, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

@Planeshifter Planeshifter Awaiting requested review from Planeshifter

Assignees

@steff456 steff456

Labels
Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steff456 @kgryte