feat: add `array/base/count-if` #1372

bad-in-coding · 2024-02-24T16:50:27Z

Resolves #1324 .

Description

What is the purpose of this pull request?

This pull request adds the package @stdlib/array/base/count-if.

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [RFC]: add @stdlib/array/base/count-if #1324

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

stdlib-bot

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Planeshifter

Thank you for taking on this package!

We should change the function signature for the predicate function to not only receive the value and this context, but also the array index and array reference itself. See comment on the main.js file. This will match the project convention and provide more flexibility to users.

lib/node_modules/@stdlib/array/base/count-if/README.md

lib/node_modules/@stdlib/array/base/count-if/package.json

lib/node_modules/@stdlib/array/base/count-if/README.md

lib/node_modules/@stdlib/array/base/count-if/lib/index.js

lib/node_modules/@stdlib/array/base/count-if/README.md

lib/node_modules/@stdlib/array/base/count-if/docs/repl.txt

lib/node_modules/@stdlib/array/base/count-if/lib/main.js

bad-in-coding · 2024-02-25T06:41:08Z

@Planeshifter I have fixed the issues :)

Planeshifter

Implementation looks great; the one thing we could improve a bit are the TypeScript definitions. Would you mind taking a look at this, please? Thanks in advance!

lib/node_modules/@stdlib/array/base/count-if/lib/index.js

lib/node_modules/@stdlib/array/base/count-if/docs/repl.txt

lib/node_modules/@stdlib/array/base/count-if/lib/main.js

lib/node_modules/@stdlib/array/base/count-if/docs/types/index.d.ts

Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Utkarsh <[email protected]>

bad-in-coding · 2024-03-02T03:48:35Z

@Planeshifter done 👍

Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Utkarsh <[email protected]>

Planeshifter

Great, thank you! Let's get this landed! Made some minor doc changes (aiming to use the 80 character line width in repl.txt more fully and adding spaces in the test.ts files per our code style) and will merge once CI passes.

lib/node_modules/@stdlib/array/base/count-if/docs/repl.txt

lib/node_modules/@stdlib/array/base/count-if/docs/types/test.ts

Signed-off-by: Philipp Burckhardt <[email protected]>

lib/node_modules/@stdlib/array/base/count-if/README.md

lib/node_modules/@stdlib/array/base/count-if/docs/repl.txt

lib/node_modules/@stdlib/array/base/count-if/lib/main.js

Signed-off-by: Philipp Burckhardt <[email protected]>

lib/node_modules/@stdlib/array/base/count-if/README.md

lib/node_modules/@stdlib/array/base/count-if/examples/index.js

Signed-off-by: Philipp Burckhardt <[email protected]>

lib/node_modules/@stdlib/array/base/count-if/README.md

Signed-off-by: Philipp Burckhardt <[email protected]>

Planeshifter · 2024-03-02T20:55:13Z

@Ut-the-pro There were a few more small lint errors that had to be fixed such as trailing spaces; if you are using a code editor such as VSCode or Sublime Text, it's a good idea to install extensions for ESLint and editorconfig to automatically format your code on save, Also, don't forget to run the stdlib make recipes for linting and testing during development after setting up your dev environment with make init.

But this should be ready to land finally, thanks again! 🎉

lib/node_modules/@stdlib/array/base/count-if/examples/index.js

Signed-off-by: Philipp Burckhardt <[email protected]>

PR-URL: stdlib-js#1372 Closes: stdlib-js#1324 Signed-off-by: Utkarsh <[email protected]> Signed-off-by: Philipp Burckhardt <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]> Reviewed-by: Athan Reines <[email protected]>

Ref: #1372 Ref: ecd3518

stdlib-bot reviewed Feb 24, 2024

View reviewed changes

Planeshifter self-requested a review February 24, 2024 20:27

kgryte changed the title ~~feat: added array/base/count-if~~ feat: add array/base/count-if Feb 24, 2024

kgryte added Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities. Needs Review A pull request which needs code review. labels Feb 24, 2024

Planeshifter requested changes Feb 24, 2024

View reviewed changes

bad-in-coding added 2 commits February 25, 2024 12:04

added array/base/count-if

e3f73ac

fixed issues & implementation of predicate functions at all places

64c19d4

bad-in-coding force-pushed the feature/array/base/count-if branch from 296d2ad to 64c19d4 Compare February 25, 2024 06:36

fixed linting issues

cc6be33

bad-in-coding requested a review from Planeshifter February 27, 2024 03:16

Planeshifter requested changes Mar 2, 2024

View reviewed changes

bad-in-coding and others added 6 commits March 2, 2024 08:56

Update lib/node_modules/@stdlib/array/base/count-if/docs/repl.txt

2bde74a

Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Utkarsh <[email protected]>

Update lib/node_modules/@stdlib/array/base/count-if/lib/index.js

2e623ce

Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Utkarsh <[email protected]>

Update lib/node_modules/@stdlib/array/base/count-if/lib/main.js

516f915

Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Utkarsh <[email protected]>

Update lib/node_modules/@stdlib/array/base/count-if/lib/main.js

e8b8661

Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Utkarsh <[email protected]>

Update lib/node_modules/@stdlib/array/base/count-if/lib/main.js

a942040

Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Utkarsh <[email protected]>

improved type declaration for predicate function

37ae175

Update lib/node_modules/@stdlib/array/base/count-if/README.md

c14e122

Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Utkarsh <[email protected]>

Planeshifter approved these changes Mar 2, 2024

View reviewed changes

Planeshifter added 3 commits March 2, 2024 12:42

Apply suggestions from code review

310ea3b

Signed-off-by: Philipp Burckhardt <[email protected]>

Update lib/node_modules/@stdlib/array/base/count-if/docs/repl.txt

a7ecf09

Signed-off-by: Philipp Burckhardt <[email protected]>

Update lib/node_modules/@stdlib/array/base/count-if/docs/repl.txt

b88c937

Signed-off-by: Philipp Burckhardt <[email protected]>

Planeshifter reviewed Mar 2, 2024

View reviewed changes

Planeshifter added 3 commits March 2, 2024 15:40

Apply suggestions from code review

3c1765f

Signed-off-by: Philipp Burckhardt <[email protected]>

Update lib/node_modules/@stdlib/array/base/count-if/README.md

d8f6acb

Signed-off-by: Philipp Burckhardt <[email protected]>

Update lib/node_modules/@stdlib/array/base/count-if/README.md

4abe551

Signed-off-by: Philipp Burckhardt <[email protected]>

Planeshifter reviewed Mar 2, 2024

View reviewed changes

Planeshifter added 4 commits March 2, 2024 15:48

Update lib/node_modules/@stdlib/array/base/count-if/README.md

555404e

Signed-off-by: Philipp Burckhardt <[email protected]>

Update lib/node_modules/@stdlib/array/base/count-if/examples/index.js

82cfd6f

Signed-off-by: Philipp Burckhardt <[email protected]>

Update lib/node_modules/@stdlib/array/base/count-if/examples/index.js

8b026b8

Signed-off-by: Philipp Burckhardt <[email protected]>

Update lib/node_modules/@stdlib/array/base/count-if/examples/index.js

e591873

Signed-off-by: Philipp Burckhardt <[email protected]>

Planeshifter reviewed Mar 2, 2024

View reviewed changes

lib/node_modules/@stdlib/array/base/count-if/README.md Outdated Show resolved Hide resolved

Update lib/node_modules/@stdlib/array/base/count-if/README.md

66f8deb

Signed-off-by: Philipp Burckhardt <[email protected]>

Planeshifter reviewed Mar 2, 2024

View reviewed changes

lib/node_modules/@stdlib/array/base/count-if/examples/index.js Outdated Show resolved Hide resolved

Planeshifter added 3 commits March 2, 2024 15:58

Update lib/node_modules/@stdlib/array/base/count-if/examples/index.js

9a400f6

Signed-off-by: Philipp Burckhardt <[email protected]>

Update test.js

085e265

Signed-off-by: Philipp Burckhardt <[email protected]>

Update benchmark.length.js

297f300

Signed-off-by: Philipp Burckhardt <[email protected]>

Planeshifter merged commit ecd3518 into stdlib-js:develop Mar 2, 2024

bad-in-coding deleted the feature/array/base/count-if branch March 4, 2024 04:35

Planeshifter removed the Needs Review A pull request which needs code review. label Mar 26, 2024

kgryte added a commit that referenced this pull request Apr 7, 2024

fix: address handling of complex arrays, refactor tests, and clean-up

310c13c

Ref: #1372 Ref: ecd3518

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add `array/base/count-if` #1372

feat: add `array/base/count-if` #1372

bad-in-coding commented Feb 24, 2024 •

edited

Loading

stdlib-bot left a comment

Planeshifter left a comment

bad-in-coding commented Feb 25, 2024

Planeshifter left a comment

bad-in-coding commented Mar 2, 2024 •

edited

Loading

Planeshifter left a comment •

edited

Loading

Planeshifter commented Mar 2, 2024

feat: add array/base/count-if #1372

feat: add array/base/count-if #1372

Conversation

bad-in-coding commented Feb 24, 2024 • edited Loading

Description

Related Issues

Questions

Other

Checklist

stdlib-bot left a comment

Choose a reason for hiding this comment

Planeshifter left a comment

Choose a reason for hiding this comment

bad-in-coding commented Feb 25, 2024

Planeshifter left a comment

Choose a reason for hiding this comment

bad-in-coding commented Mar 2, 2024 • edited Loading

Planeshifter left a comment • edited Loading

Choose a reason for hiding this comment

Planeshifter commented Mar 2, 2024

feat: add `array/base/count-if` #1372

feat: add `array/base/count-if` #1372

bad-in-coding commented Feb 24, 2024 •

edited

Loading

bad-in-coding commented Mar 2, 2024 •

edited

Loading

Planeshifter left a comment •

edited

Loading