Skip to content

refactor: improve type specificity for utils/group-own #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 6, 2024

Conversation

Shubh942
Copy link
Contributor

@Shubh942 Shubh942 commented Mar 1, 2024

Resolves #1085

Description

What is the purpose of this pull request?

This pull request:

  • Adds generics for improved type safety for the group-own function.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@Shubh942
Copy link
Contributor Author

Shubh942 commented Mar 1, 2024

@Planeshifter @kgryte please review this pr

@Planeshifter
Copy link
Member

@Shubh942 Thanks for your efforts, but as-is this cannot be merged due to various issues:

  • it incorrectly removes the options parameter from the function signature (notice that the returns option also influences the shape of the returned output, see the README.md)
  • irrespective of that, it assumes that the values of the returned record are all string arrays (string[]); while true for the example code, the function is not limited to string values.

@Planeshifter Planeshifter added the Needs Changes Pull request which needs changes before being merged. label Mar 1, 2024
@Shubh942
Copy link
Contributor Author

Shubh942 commented Mar 2, 2024

@Planeshifter I have made the changes.

@kgryte kgryte added the TypeScript Issue involves or relates to TypeScript. label Mar 17, 2024
@kgryte kgryte requested a review from Planeshifter March 17, 2024 10:02
@kgryte kgryte changed the title refactor: declare type for group-own refactor: improve type specificity for utils/group-own Mar 17, 2024
@Shubh942
Copy link
Contributor Author

@Planeshifter would you please review this PR

@Planeshifter Planeshifter merged commit ec4730b into stdlib-js:develop Oct 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Changes Pull request which needs changes before being merged. TypeScript Issue involves or relates to TypeScript.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: improve type declarations for @stdlib/utils/group-own
4 participants