Skip to content

feat: add string/base/last #1697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 8, 2024
Merged

feat: add string/base/last #1697

merged 4 commits into from
Mar 8, 2024

Conversation

adityacodes30
Copy link
Contributor

@adityacodes30 adityacodes30 commented Mar 4, 2024 •
edited
Loading

Resolves #1696

Description

What is the purpose of this pull request?

This pull request adds the package @stdlib/string/base/last

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Planeshifter Planeshifter changed the title feat: add string/base/last feat: add string/base/last Mar 4, 2024
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Mar 4, 2024
@adityacodes30 adityacodes30 mentioned this pull request Mar 5, 2024
Closed
3 tasks
@adityacodes30
Copy link
Contributor Author

tests pass - this pr is ready for review @kgryte @Planeshifter

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities. JavaScript Issue involves or relates to JavaScript. labels Mar 6, 2024
Planeshifter
Planeshifter approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @adityacodes30!

@Planeshifter Planeshifter merged commit 3b6b680 into stdlib-js:develop Mar 8, 2024
@adityacodes30 adityacodes30 mentioned this pull request Mar 25, 2024
Closed
6 tasks
@Planeshifter Planeshifter removed the Needs Review A pull request which needs code review. label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add @stdlib/string/base/last
3 participants
@adityacodes30 @Planeshifter @kgryte