Skip to content

feat: add C implementation for math/base/special/log2 #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 12, 2024
Merged

feat: add C implementation for math/base/special/log2 #1717

merged 10 commits into from
Mar 12, 2024

Conversation

aman-095
Copy link
Member

@aman-095 aman-095 commented Mar 5, 2024

Description

What is the purpose of this pull request?

This RFC proposes adding native C implementation for @stdlib/math/base/special/log2

double stdlib_base_log2( const double x )

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Planeshifter Planeshifter changed the title feat: Add C implementation for @stdlib/math/base/special/log2 feat: add C implementation for math/base/special/log2 Mar 6, 2024
Pranavchiku
Pranavchiku suggested changes Mar 6, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. Requested few changes.

Pranavchiku
Pranavchiku approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, this is good to merge. Thanks @aman-095 !

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. C Issue involves or relates to C. Ready To Merge A pull request which is ready to be merged. labels Mar 6, 2024
@aman-095
Copy link
Member Author

aman-095 commented Mar 6, 2024

Thanks @Pranavchiku looking forward to more contributions.

kgryte
kgryte requested changes Mar 6, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @aman-095. I believe there is a bug in the implementation and there are a few style/doc changes which need to be made before this can be merged.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Ready To Merge A pull request which is ready to be merged. labels Mar 6, 2024
Pranavchiku
Pranavchiku suggested changes Mar 6, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment, rest all looks good.

Pranavchiku
Pranavchiku approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Pranavchiku Pranavchiku added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 6, 2024
kgryte
kgryte requested changes Mar 7, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation matches the JS implementation, with the exception of integer typing. Would be good to get that sorted before merging.

@kgryte kgryte removed the Ready To Merge A pull request which is ready to be merged. label Mar 7, 2024
@aman-095
Copy link
Member Author

aman-095 commented Mar 8, 2024

@kgryte applied all changes please review.

Planeshifter
Planeshifter approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's land this one.

@Planeshifter Planeshifter merged commit d8f6700 into stdlib-js:develop Mar 12, 2024
@aman-095 aman-095 mentioned this pull request Apr 1, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte requested changes

@Planeshifter Planeshifter Planeshifter approved these changes

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aman-095 @Planeshifter @kgryte @Pranavchiku