Skip to content

refactor: update blas/ext/base/snansumkbn to follow current project conventions #1735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 20, 2024
Merged

refactor: update blas/ext/base/snansumkbn to follow current project conventions #1735

merged 3 commits into from
Apr 20, 2024

Conversation

itsspriyansh
Copy link
Contributor

@itsspriyansh itsspriyansh commented Mar 6, 2024 •
edited
Loading

Resolves #1529

Description

What is the purpose of this pull request?

This pull request:

  • refactors blas/ext/base/snansumkbn to follow current project conventions.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@itsspriyansh itsspriyansh mentioned this pull request Mar 6, 2024
Closed
3 tasks
@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. labels Mar 6, 2024
@Planeshifter Planeshifter changed the title refactor: update blas/ext/base/snansumkbn to follow current projects refactor: update blas/ext/base/snansumkbn to follow current project conventions Mar 6, 2024
@kgryte
Copy link
Member

kgryte commented Mar 10, 2024

@itsspriyansh Mind checking the box in the OP that you've read the contributing guidelines?

@itsspriyansh
Copy link
Contributor Author

@kgryte done!

@Planeshifter Planeshifter self-requested a review March 24, 2024 18:53
@kgryte
Copy link
Member

kgryte commented Apr 14, 2024

@itsspriyansh Did you intentionally close this PR?

@kgryte
Copy link
Member

kgryte commented Apr 14, 2024

Feel free to reopen, if not. We are still working through our backlog of reviews.

@itsspriyansh itsspriyansh reopened this Apr 16, 2024
@itsspriyansh
Copy link
Contributor Author

Hey @kgryte ,
I have reopened the PR. Please do take a look.

Planeshifter
Planeshifter approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help, @itsspriyansh!

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Apr 20, 2024
@Planeshifter Planeshifter merged commit 0f917bd into stdlib-js:develop Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/snansumkbn to follow current project conventions
3 participants
@itsspriyansh @kgryte @Planeshifter