Skip to content

docs: improve README examples of stats/iter namespace . #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

docs: improve README examples of stats/iter namespace . #1738

wants to merge 3 commits into from

Conversation

kumarsuraj212003
Copy link
Contributor

Resolves #1652.

Description

What is the purpose of this pull request?

This pull request:

  • a
  • b
  • c

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@Planeshifter Planeshifter added Documentation Improvements, additions, or changes to documentation. JavaScript Issue involves or relates to JavaScript. Needs Review A pull request which needs code review. labels Mar 6, 2024
@steff456 steff456 self-requested a review March 6, 2024 19:37
@steff456 steff456 removed the Needs Review A pull request which needs code review. label Mar 6, 2024
Copy link
Contributor

@steff456 steff456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kumarsuraj212003 for opening this PR!

I left two comments and please check the failing CI for the example you added.

Also, please add the requested information in the description of this PR, specially the first section describing what this PR is doing.

@steff456 steff456 added the Needs Changes Pull request which needs changes before being merged. label Mar 6, 2024
kumarsuraj212003 and others added 2 commits March 7, 2024 19:34
Co-authored-by: Stephannie Jimenez Gacha <[email protected]>
Signed-off-by: Suraj kumar <[email protected]>
Co-authored-by: Stephannie Jimenez Gacha <[email protected]>
Signed-off-by: Suraj kumar <[email protected]>
Copy link
Contributor Author

@kumarsuraj212003 kumarsuraj212003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i follow stuggested changes

@kumarsuraj212003
Copy link
Contributor Author

Screenshot (12)
can u please tell me why am i getting this error.
i have setup stdlib locally i also varified by running benchmarks and tests ,it woks smoothly

@kumarsuraj212003 kumarsuraj212003 deleted the patch-2 branch March 7, 2024 15:29
@kumarsuraj212003 kumarsuraj212003 restored the patch-2 branch March 7, 2024 15:29
@steff456
Copy link
Contributor

Hi @kumarsuraj212003, that error indicate that when the example is running, it is returning null instead of the expected value. Can you please check if everything is running smoothly locally by running the lint command make lint-markdown-files FILES="<Type here the path to the readme file>"? You can double check if everything is importing correctly as part of the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements, additions, or changes to documentation. JavaScript Issue involves or relates to JavaScript. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: improve README examples of stats/iter namespace
3 participants