Skip to content

refactor: update blas/ext/base/dapxsum to follow current project conventions #1793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 26, 2024

Conversation

nightknighto
Copy link
Contributor

Resolves #1465 .

Description

This pull request refactors blas/ext/base/dapxsum to follow current project conventions.

Related Issues

Related issues #788 , #1152

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. labels Mar 8, 2024
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 17, 2024
@kgryte kgryte self-requested a review March 17, 2024 11:47
@kgryte kgryte added the Enhancement Issue or pull request for enhancing existing functionality. label Mar 25, 2024
@@ -35,6 +35,10 @@
],
"libpath": [],
"dependencies": [
"@stdlib/napi/export",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has mixed TABS and spaces. The indentation should be 2-space.

This file is also missing separate build configurations for benchmarks and examples. See, e.g., https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/blas/ext/base/dapxsumors/manifest.json.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the missing confs.
For the indentation thing, I've run the document formatting tool on the file and they all look 2-spaces indented. If still not the correct result, please let me know how to deal with it

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @Deadreyo. Left a few comments. I also believe that there are missing changes to test files and some other files in lib. E.g., see this recent PR: https://github.com/stdlib-js/stdlib/pull/1993/files. Once resolved, this PR should be good to move forward.

@nightknighto nightknighto requested a review from kgryte March 25, 2024 11:27
@nightknighto
Copy link
Contributor Author

Updated missing changes in lib and test files

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a review and the changes look all good to me. Thank you for working on this, @Deadreyo.

Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter Planeshifter merged commit b9f2025 into stdlib-js:develop Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/dapxsum to follow current project conventions
3 participants