-
-
Notifications
You must be signed in to change notification settings - Fork 805
refactor: update blas/ext/ssort2ins
to follow current project conventions
#1874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Pranavchiku I was not able to find any refactoring in benchmark, if there is any please let me know |
Resolving package path... make: *** [/home/varad/Desktop/stdlib/tools/make/lib/examples/c.mk:84: examples-c-files] Error 1 Encountered an error when running C examples |
how could i resolve this error I think this is an error coming from addon.c @kgryte @Planeshifter |
lib/node_modules/@stdlib/blas/ext/base/ssort2ins/lib/ndarray.native.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @vr-varad. In addition to the comments I left, this PR is missing changes to test files and other documentation examples, include repl.txt
and JSDoc comments.
@stdlib/blas/ext/ssort2ins
to follow current project conventionsblas/ext/ssort2ins
to follow current project conventions
@Planeshifter @kgryte I'm encountering an error that's causing a bit of a roadblock for me. Would you be able to lend me a hand in troubleshooting it? |
lib/node_modules/@stdlib/blas/ext/base/ssort2ins/lib/ndarray.native.js
Outdated
Show resolved
Hide resolved
@vr-varad It looks like the argument juggling in |
@Planeshifter @kgryte I made the necessary changes and the issue is finally resolved Thank you @kgryte . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @vr-varad! Looked all good now; will merge shortly.
Description
This pull request refactors the
@stdlib/blas/ext/ssort@ins
to follow current project conventionsRelated Issues
This pull request:
blas/ext/base/ssort2ins
to follow current project conventions #1535Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers