Skip to content

refactor: update blas/ext/ssort2ins to follow current project conventions #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Apr 28, 2024
Merged

refactor: update blas/ext/ssort2ins to follow current project conventions #1874

merged 36 commits into from
Apr 28, 2024

Conversation

vr-varad
Copy link
Contributor

Description

What is the purpose of this pull request?

This pull request refactors the @stdlib/blas/ext/ssort@ins to follow current project conventions

Checklist

  • update readme.md
  • docs
  • src
  • include.gypi
  • manifest.json
  • package.json
  • lib
  • examples
  • benchmark
  • test

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@vr-varad
Copy link
Contributor Author

@Pranavchiku I was not able to find any refactoring in benchmark, if there is any please let me know

@vr-varad
Copy link
Contributor Author

Resolving package path...
Package path: /home/varad/Desktop/stdlib/lib/node_modules/@stdlib/blas/ext/base/ssort2ins
Resolving package manifest...
Successfully resolved package manifest.
Resolving include directories...
Resolving source files...
Resolving libraries...
Resolving library paths...
Compiling example...
make[1]: Entering directory '/home/varad/Desktop/stdlib/lib/node_modules/@stdlib/blas/ext/base/ssort2ins/examples/c'
In file included from /home/varad/Desktop/stdlib/lib/node_modules/@stdlib/napi/argv/include/stdlib/napi/argv.h:22,
from /home/varad/Desktop/stdlib/lib/node_modules/@stdlib/napi/argv-float/include/stdlib/napi/argv_float.h:22,
from /home/varad/Desktop/stdlib/lib/node_modules/@stdlib/napi/argv-float/src/main.c:19:
/home/varad/Desktop/stdlib/lib/node_modules/@stdlib/assert/napi/status-ok/include/stdlib/assert/napi/status_ok.h:22:10: fatal error: node_api.h: No such file or directory
22 | #include <node_api.h>
| ^~~~~~~~~~~~
compilation terminated.
In file included from /home/varad/Desktop/stdlib/lib/node_modules/@stdlib/assert/napi/is-type/src/main.c:19:
/home/varad/Desktop/stdlib/lib/node_modules/@stdlib/assert/napi/is-type/include/stdlib/assert/napi/is_type.h:22:10: fatal error: node_api.h: No such file or directory
22 | #include <node_api.h>
| ^~~~~~~~~~~~
compilation terminated.
In file included from /home/varad/Desktop/stdlib/lib/node_modules/@stdlib/assert/napi/equal-types/src/main.c:19:
/home/varad/Desktop/stdlib/lib/node_modules/@stdlib/assert/napi/equal-types/include/stdlib/assert/napi/equal_types.h:22:10: fatal error: node_api.h: No such file or directory
22 | #include <node_api.h>
| ^~~~~~~~~~~~
compilation terminated.
In file included from /home/varad/Desktop/stdlib/lib/node_modules/@stdlib/napi/argv/include/stdlib/napi/argv.h:22,
from /home/varad/Desktop/stdlib/lib/node_modules/@stdlib/napi/argv-int64/include/stdlib/napi/argv_int64.h:22,
from /home/varad/Desktop/stdlib/lib/node_modules/@stdlib/napi/argv-int64/src/main.c:19:
/home/varad/Desktop/stdlib/lib/node_modules/@stdlib/assert/napi/status-ok/include/stdlib/assert/napi/status_ok.h:22:10: fatal error: node_api.h: No such file or directory
22 | #include <node_api.h>
| ^~~~~~~~~~~~
compilation terminated.
In file included from /home/varad/Desktop/stdlib/lib/node_modules/@stdlib/napi/argv/include/stdlib/napi/argv.h:22,
from /home/varad/Desktop/stdlib/lib/node_modules/@stdlib/napi/argv-strided-float64array/include/stdlib/napi/argv_strided_float64array.h:22,
from /home/varad/Desktop/stdlib/lib/node_modules/@stdlib/napi/argv-strided-float64array/src/main.c:19:
/home/varad/Desktop/stdlib/lib/node_modules/@stdlib/assert/napi/status-ok/include/stdlib/assert/napi/status_ok.h:22:10: fatal error: node_api.h: No such file or directory
22 | #include <node_api.h>
| ^~~~~~~~~~~~
compilation terminated.
In file included from /home/varad/Desktop/stdlib/lib/node_modules/@stdlib/napi/argv/include/stdlib/napi/argv.h:22,
from /home/varad/Desktop/stdlib/lib/node_modules/@stdlib/napi/argv-float64array/include/stdlib/napi/argv_float64array.h:22,
from /home/varad/Desktop/stdlib/lib/node_modules/@stdlib/napi/argv-float64array/src/main.c:19:
/home/varad/Desktop/stdlib/lib/node_modules/@stdlib/assert/napi/status-ok/include/stdlib/assert/napi/status_ok.h:22:10: fatal error: node_api.h: No such file or directory
22 | #include <node_api.h>
| ^~~~~~~~~~~~
compilation terminated.
In file included from /home/varad/Desktop/stdlib/lib/node_modules/@stdlib/assert/napi/equal-typedarray-types/src/main.c:19:
/home/varad/Desktop/stdlib/lib/node_modules/@stdlib/assert/napi/equal-typedarray-types/include/stdlib/assert/napi/equal_typedarray_types.h:22:10: fatal error: node_api.h: No such file or directory
22 | #include <node_api.h>
| ^~~~~~~~~~~~
compilation terminated.
In file included from /home/varad/Desktop/stdlib/lib/node_modules/@stdlib/assert/napi/is-typedarray/src/main.c:19:
/home/varad/Desktop/stdlib/lib/node_modules/@stdlib/assert/napi/is-typedarray/include/stdlib/assert/napi/is_typedarray.h:22:10: fatal error: node_api.h: No such file or directory
22 | #include <node_api.h>
| ^~~~~~~~~~~~
compilation terminated.
make[1]: *** [Makefile:124: example.out] Error 1
make[1]: Leaving directory '/home/varad/Desktop/stdlib/lib/node_modules/@stdlib/blas/ext/base/ssort2ins/examples/c'
Error when attempting to compile example.
ERROR: An error was encountered during execution.

make: *** [/home/varad/Desktop/stdlib/tools/make/lib/examples/c.mk:84: examples-c-files] Error 1

Encountered an error when running C examples

@vr-varad
Copy link
Contributor Author

how could i resolve this error I think this is an error coming from addon.c @kgryte @Planeshifter

@kgryte
Copy link
Member

kgryte commented Mar 14, 2024

@vr-varad See 07514b1. You need to update your manifest.json configurations accordingly.

@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. labels Mar 14, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @vr-varad. In addition to the comments I left, this PR is missing changes to test files and other documentation examples, include repl.txt and JSDoc comments.

@kgryte kgryte changed the title refactor: update @stdlib/blas/ext/ssort2ins to follow current project conventions refactor: update blas/ext/ssort2ins to follow current project conventions Mar 14, 2024
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 14, 2024
@vr-varad
Copy link
Contributor Author

@Planeshifter @kgryte I'm encountering an error that's causing a bit of a roadblock for me. Would you be able to lend me a hand in troubleshooting it?

@kgryte
Copy link
Member

kgryte commented Mar 25, 2024

@vr-varad It looks like the argument juggling in lib/ndarray.native.js is not correct; hence, the test failure.

@vr-varad
Copy link
Contributor Author

@Planeshifter @kgryte I made the necessary changes and the issue is finally resolved Thank you @kgryte .
You can review it.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vr-varad! Looked all good now; will merge shortly.

@Planeshifter Planeshifter merged commit f1b1fce into stdlib-js:develop Apr 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/ssort2ins to follow current project conventions
3 participants