refactor: update blas/ext/base/ssortsh to follow current project conventions
#1905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benchmark now used utility functions for creating random arrays instead of loops. Changed addon from cpp to c.
…entions updated benchmark files to generate random arrays using utility functions instead of loops. added addon.c and used argv macros for handling callback arguments. removed the use of float in repl.
stdlib-bot
added
the
BLAS
stdlib-bot
reviewed
Mar 15, 2024
Sivam2313
changed the title
blas/ext/base/ssortsh to follow current project conventions
kgryte
added
Enhancement
kgryte
changed the title
blas/ext/base/ssortsh to follow current project conventionsblas/ext/base/ssortsh to follow current project conventions
fixed all the failing benchmark files.
|
Fixed the failing benchmarks |
|
@kgryte can you please review my pr |
Planeshifter
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1539 .
Description
This pull request:
blas/ext/base/ssortshto follow current project conventionsRelated Issues
This pull request:
blas/ext/base/ssortshto follow current project conventions #1539Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers