Skip to content

refactor: update blas/ext/base/scusumors #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 21, 2024

Conversation

rxbryan
Copy link
Contributor

@rxbryan rxbryan commented Mar 18, 2024

updates blas/ext/base/scusumors to follow current project conventions

Related Issues

Does this pull request have any related issues?
#788
#1152

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 18, 2024
updates blas/ext/base/scusumors to follow current project conventions

Fixes: stdlib-js#1519
@rxbryan rxbryan force-pushed the refactor-scusumors branch from 4f35fa9 to b4fdaac Compare March 18, 2024 15:02
@Planeshifter Planeshifter changed the title refactor: update blas/ext/base/scusumors refactor: update blas/ext/base/scusumors Mar 20, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there; just a few changes needed. Thanks!

@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. labels Mar 20, 2024
rxbryan and others added 7 commits March 20, 2024 03:17
…sumors.native.js

Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Bryan Elee <[email protected]>
…sumors.js

Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Bryan Elee <[email protected]>
…x.js

Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Bryan Elee <[email protected]>
rxbryan and others added 4 commits March 20, 2024 03:19
…rray.native.js

Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Bryan Elee <[email protected]>
…rray.js

Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Bryan Elee <[email protected]>
@rxbryan rxbryan force-pushed the refactor-scusumors branch from 104c3ef to 0f99de8 Compare March 20, 2024 02:38
Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Bryan Elee <[email protected]>
@rxbryan rxbryan force-pushed the refactor-scusumors branch from 0f99de8 to cd12a1a Compare March 20, 2024 02:48
@rxbryan
Copy link
Contributor Author

rxbryan commented Mar 20, 2024

Hi @Planeshifter, I have implemented the changes

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will merge after CI has passed.

@Planeshifter Planeshifter merged commit 548f903 into stdlib-js:develop Mar 21, 2024
8 checks passed
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Mar 21, 2024
kgryte added a commit that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/scusumors to follow current project conventions
4 participants