-
-
Notifications
You must be signed in to change notification settings - Fork 812
refactor: update blas/ext/base/scusumors
#1945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates blas/ext/base/scusumors to follow current project conventions Fixes: stdlib-js#1519
4f35fa9
to
b4fdaac
Compare
blas/ext/base/scusumors
lib/node_modules/@stdlib/blas/ext/base/scusumors/examples/index.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumors/examples/index.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumors/test/test.ndarray.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumors/test/test.ndarray.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumors/test/test.scusumors.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumors/test/test.scusumors.native.js
Outdated
Show resolved
Hide resolved
Planeshifter
requested changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there; just a few changes needed. Thanks!
…sumors.native.js Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Bryan Elee <[email protected]>
…sumors.js Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Bryan Elee <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Bryan Elee <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Bryan Elee <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Bryan Elee <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Bryan Elee <[email protected]>
…x.js Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Bryan Elee <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Bryan Elee <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Bryan Elee <[email protected]>
…rray.native.js Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Bryan Elee <[email protected]>
…rray.js Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Bryan Elee <[email protected]>
104c3ef
to
0f99de8
Compare
Co-authored-by: Philipp Burckhardt <[email protected]> Signed-off-by: Bryan Elee <[email protected]>
0f99de8
to
cd12a1a
Compare
Hi @Planeshifter, I have implemented the changes |
Planeshifter
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Will merge after CI has passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BLAS
Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).
C
Issue involves or relates to C.
Enhancement
Issue or pull request for enhancing existing functionality.
Native Addons
Issue involves or relates to Node.js native add-ons.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates blas/ext/base/scusumors to follow current project conventions
Related Issues
This pull request:
blas/ext/base/scusumors
to follow current project conventions #1519Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers