refactor: update blas/ext/base/dasumpw to follow current project conventions
#1998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
added
the
BLAS
|
@Planeshifter please review this PR |
Signed-off-by: utkarsh_raj <[email protected]>
lib/node_modules/@stdlib/blas/ext/base/dasumpw/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dasumpw/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dasumpw/lib/ndarray.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dasumpw/examples/index.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dasumpw/benchmark/benchmark.ndarray.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dasumpw/benchmark/benchmark.ndarray.js
Outdated
Show resolved
Hide resolved
kgryte
added
Enhancement
kgryte
changed the title
blas/ext/base/dasumpw to follow current project conventionsblas/ext/base/dasumpw to follow current project conventions
lib/node_modules/@stdlib/blas/ext/base/dasumpw/test/test.dasumpw.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dasumpw/test/test.dasumpw.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dasumpw/test/test.ndarray.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dasumpw/test/test.ndarray.native.js
Outdated
Show resolved
Hide resolved
Planeshifter
requested changes
Mar 23, 2024
|
@Planeshifter I have made the suggested changes |
Closed
6 tasks
Planeshifter
added
the
Needs Changes
Planeshifter
requested changes
Mar 25, 2024
There was a problem hiding this comment.
@rajutkarsh07 CI checks are currently failing. Looks like we need an additional empty line at L51 of repl.txt and I think c_dasum in the addon.c file has to be replaced with stdlib_strided_dasumpw for tests to pass. I also believe some changes to manifest.json are still outstanding. Hopefully fixing up these issues won't be too burdensome. Thanks for working on this PR!
|
@Planeshifter made the changes in manifest.json and addon.c |
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Planeshifter
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
After a few additional changes to the manifest.json, CI checks are now passing. Will merge shortly. Thank you @rajutkarsh07 for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1470
Description
update blas/ext/base/dasumpw to follow current project conventions
This pull request:
blas/ext/base/dasumpwto follow current project conventions #1470Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers