Skip to content

refactor: update blas/ext/base/dcusumkbn2 to follow current project conventions #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 24, 2024
Merged

refactor: update blas/ext/base/dcusumkbn2 to follow current project conventions #2020

merged 5 commits into from
Mar 24, 2024
+191 −307

Conversation

vr-varad
Copy link
Contributor

@vr-varad vr-varad commented Mar 24, 2024 •
edited
Loading

Description

refactor: update blas/ext/base/dcusumkbn2 to follow current project conventions

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

Sorry, something went wrong.

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 24, 2024
@vr-varad vr-varad changed the title refactor: update blas/ext/base/dcusumkbn2 to follow current project conventions refactor: update blas/ext/base/dcusumkbn2 to follow current project conventions Mar 24, 2024
@vr-varad
fix: resolved test errors
Loading
Loading status checks…
90d25bd
@vr-varad
Copy link
Contributor Author

Dear @kgryte @Pranavchiku and @Planeshifter. I've implemented the requested changes. Would you be able to take a moment to review them when you have some time? Your feedback would be greatly appreciated. Thank you kindly.

@Planeshifter Planeshifter added Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. Needs Review A pull request which needs code review. labels Mar 24, 2024
@Planeshifter Planeshifter self-requested a review March 24, 2024 18:29
@Planeshifter
Apply suggestions from code review

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
003bb2c 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
style: fix indentation

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
48d64d9 
Signed-off-by: Philipp Burckhardt <[email protected]>
Planeshifter
Planeshifter approved these changes Mar 24, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

Updated indentation in manifest.json, but otherwise this looks all good to me.

Will merge shortly after CI checks have passed.

@Planeshifter Planeshifter merged commit 71a78a5 into stdlib-js:develop Mar 24, 2024
8 checks passed
@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/dcusumkbn2 to follow current project conventions
3 participants
@vr-varad @Planeshifter @stdlib-bot