Skip to content

refactor blas/ext/base/dcusumkbn to follow current project conventions #2036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 29, 2024
Merged

refactor blas/ext/base/dcusumkbn to follow current project conventions #2036

merged 13 commits into from
Mar 29, 2024

Conversation

itskdhere
Copy link
Contributor

Resolves #1472 .

Description

What is the purpose of this pull request?

This pull request:

  • refactors the existing implementation of blas/ext/base/dcusumkbn to follow the current project convention.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 25, 2024
@itskdhere itskdhere mentioned this pull request Mar 25, 2024
Closed
1 task
@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 25, 2024
Pranavchiku
Pranavchiku suggested changes Mar 26, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes required, once addressed this will be good to merge.

@Pranavchiku Pranavchiku added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 26, 2024
@itskdhere
Copy link
Contributor Author

itskdhere commented Mar 26, 2024 •
edited
Loading

@Pranavchiku I've applied the suggested changes. And all the checks are now passing.

kgryte
kgryte requested changes Mar 26, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current addon.c implementation is incorrect.

@itskdhere
Copy link
Contributor Author

itskdhere commented Mar 26, 2024 •
edited
Loading

The current addon.c implementation is incorrect.

@kgryte I've changed it from int64 to double

But now the CI is failing because it looks like it can't find @stdlib/napi/argv_double.h
Should I revert 5d12725 ?

@kgryte
Copy link
Member

kgryte commented Mar 26, 2024

No. You should not revert it. You did not update the manifest.json accordingly to reflect those changes in addon.c.

@itskdhere
Copy link
Contributor Author

No. You should not revert it. You did not update the manifest.json accordingly to reflect those changes in addon.c.

Ok. Now it's clear to me.

Planeshifter
Planeshifter approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thank you!

@Planeshifter Planeshifter merged commit 47cc515 into stdlib-js:develop Mar 29, 2024
8 checks passed
@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte requested changes

@Pranavchiku Pranavchiku Pranavchiku requested changes

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/dcusumkbn to follow current project conventions
5 participants
@itskdhere @kgryte @Planeshifter @Pranavchiku @stdlib-bot