Skip to content

refactor: update blas/ext/base/dsortins to follow current project convention #2055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 28, 2024
Merged

refactor: update blas/ext/base/dsortins to follow current project convention #2055

merged 5 commits into from
Apr 28, 2024

Conversation

Shubh942
Copy link
Contributor

@Shubh942 Shubh942 commented Mar 26, 2024 •
edited
Loading

Resolves #1499 .

Description

refactor: update blas/ext/base/dsortins to follow current project conventions

Related Issues

Does this pull request have any related issues?

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 26, 2024
@Shubh942
Copy link
Contributor Author

@kgryte @Planeshifter @Pranavchiku can you please review this PR

@Shubh942 Shubh942 mentioned this pull request Mar 27, 2024
Closed
6 tasks
@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 28, 2024
@Planeshifter Planeshifter self-requested a review April 28, 2024 18:50
Planeshifter
Planeshifter approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some clean-up and will merge once CI has passed. Thank you!

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Apr 28, 2024
@Planeshifter Planeshifter merged commit e82767d into stdlib-js:develop Apr 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/dsortins to follow current project conventions
3 participants
@Shubh942 @Planeshifter @stdlib-bot