Skip to content

feat: add blas/base/zscal #2253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 10, 2024
Merged

feat: add blas/base/zscal #2253

merged 8 commits into from
Jun 10, 2024

Conversation

aman-095
Copy link
Member

Description

What is the purpose of this pull request?

This RFC proposes to add a routine to scale values of input complex double-precision floating-point vector by another complex double-precision floating-point constant vector as defined in BLAS Level 1 routines. Specifically adding @stdlib/blas/base/zscal is proposed.

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label May 20, 2024
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label May 23, 2024
@Pranavchiku Pranavchiku added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jun 8, 2024
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed we need to update include paths.

@Pranavchiku Pranavchiku marked this pull request as draft June 8, 2024 11:55
@kgryte kgryte mentioned this pull request Jun 8, 2024
1 task
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Jun 8, 2024
@aman-095 aman-095 marked this pull request as ready for review June 10, 2024 08:44
@aman-095
Copy link
Member Author

Hey, @kgryte, I have applied the required changes based on cscal

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @aman-095!

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Jun 10, 2024
@kgryte kgryte merged commit 76e73a5 into stdlib-js:develop Jun 10, 2024
8 checks passed
aman-095 added a commit to aman-095/stdlib that referenced this pull request Jun 11, 2024
PR-URL: stdlib-js#2253
Ref: stdlib-js#2039
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
aman-095 added a commit to aman-095/stdlib that referenced this pull request Jun 13, 2024
PR-URL: stdlib-js#2253
Ref: stdlib-js#2039
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants