fix: prevent property access if properties couldn't be resolved when syntax highlighting in the REPL #2412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
MemberExpression
can't be resolved into a definite property name (without any script execution) when tokenizing.a[b.c]
, ifb.c
doesn't correspond to a literal value in context, (say it's a function or an object), then no point in trying to computea[Function]
. To actually be able to compute it, the function (b.c
) needs to be eagerly evaluated to resolve it into a definite literal name.Checklist
@stdlib-js/reviewers