Skip to content

feat!: add blas/base/strmv #2535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Aug 1, 2024
Merged

feat!: add blas/base/strmv #2535

merged 28 commits into from
Aug 1, 2024

Conversation

aman-095
Copy link
Member

@aman-095 aman-095 commented Jul 8, 2024

Progresses: #2039.

Description

What is the purpose of this pull request?

This RFC proposes to add a routine to perform one of the matrix-vector operations x = A*x, or x = A**T*x, where x is an N element vector, and A is an N by N unit, or non-unit, upper or lower triangular matrix as defined in BLAS Level 2 routines. Specifically adding @stdlib/blas/base/strmv is proposed.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Jul 8, 2024
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Jul 9, 2024
@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Jul 9, 2024
@kgryte
Copy link
Member

kgryte commented Jul 9, 2024

@aman-095 Thanks for working on this. As previously discussed, we need to refactor the main and ndarray APIs to call a common "base" implementation in order to reduce code duplication. Rather than needing to perform a separate refactoring later, I suggest going ahead and doing that in this PR.

@kgryte
Copy link
Member

kgryte commented Jul 9, 2024

The changes thus far made and the refactoring will also need to be applied to dtrmv.

@kgryte kgryte mentioned this pull request Jul 9, 2024
1 task
@aman-095
Copy link
Member Author

Hey, @kgryte I have applied the required changes here and the similar in #2540.

@aman-095 aman-095 added the Needs Review A pull request which needs code review. label Jul 11, 2024
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Jul 11, 2024
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jul 14, 2024
@aman-095 aman-095 added the Needs Review A pull request which needs code review. label Jul 24, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @aman-095!

@kgryte kgryte changed the title feat: add blas/base/strmv feat!: add blas/base/strmv Aug 1, 2024
@kgryte kgryte removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Aug 1, 2024
@kgryte kgryte merged commit 2254a56 into stdlib-js:develop Aug 1, 2024
12 checks passed
gunjjoshi pushed a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
BREAKING CHANGE: rename `none` transpose operation to `no-transpose` in `@stdlib/types`

To migrate, users should change their usage of `none` to `no-transpose`. This change enhances code readability and aligns the string literal with the C enumeration constant.

PR-URL: stdlib-js#2535
Ref: stdlib-js#2039
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants