feat: add lapack/base/dpttrf
#2578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pranavchiku
added
the
LAPACK
Pranavchiku
commented
Jul 13, 2024
Pranavchiku
commented
Jul 13, 2024
Pranavchiku
commented
Jul 13, 2024
kgryte
reviewed
Jul 14, 2024
kgryte
reviewed
Jul 14, 2024
kgryte
reviewed
Jul 14, 2024
kgryte
reviewed
Jul 14, 2024
kgryte
reviewed
Jul 14, 2024
kgryte
reviewed
Jul 14, 2024
lib/node_modules/@stdlib/lapack/base/dpttrf/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Jul 14, 2024
kgryte
reviewed
Jul 14, 2024
kgryte
reviewed
Jul 14, 2024
kgryte
reviewed
Jul 14, 2024
kgryte
reviewed
Jul 14, 2024
kgryte
added
the
Needs Changes
Pranavchiku
added
Needs Review
…/Pranavchiku/2578
kgryte
approved these changes
Jul 28, 2024
There was a problem hiding this comment.
LGTM. Thanks for working on this, @Pranavchiku.
I did a fair amount of clean-up, especially in tightening up the implementation by reducing the number of arithmetic operations and in adding test cases. For this package, you were light on tests, especially in ensuring that status code return values were handled correctly. You had incorrectly had k be based on the underlying buffer index (e.g., offsetD + (i*strideD)), rather than the view index, which is what would make sense from a user POV and ensures consistent status code values between the two APIs and ensures consistency with the LAPACK docs where info corresponds to the principal minor of order k. Allowing k to exceed N simply doesn't make sense.
gunjjoshi
pushed a commit
to gunjjoshi/stdlib
that referenced
this pull request
Aug 21, 2024
PR-URL: stdlib-js#2578 Ref: stdlib-js#2464 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2464.
Description
This pull request adds JS implementation for
lapack/base/dpttrf.Related Issues
No.
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers