Skip to content

feat: add C implementation for stats/base/dists/arcsine/median #4066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 3, 2025
Merged

feat: add C implementation for stats/base/dists/arcsine/median #4066

merged 9 commits into from
Apr 3, 2025

Conversation

pranav-1720
Copy link
Contributor

@pranav-1720 pranav-1720 commented Dec 19, 2024 •
edited by kgryte
Loading

Progresses #3403.

Description

What is the purpose of this pull request?

This pull request:

  • Adds C implementation for @stdlib/stats/base/dists/arcsine/median

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@pranav-1720
feat: add C implementation for @stdlib/stats/base/dists/arcsine/median
48020c0 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 19, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 19, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/arcsine/median $\color{red}176/179$
$\color{green}+98.32\%$ 		$\color{green}6/6$
$\color{green}+100.00\%$ 		$\color{red}1/2$
$\color{green}+50.00\%$ 		$\color{red}176/179$
$\color{green}+98.32\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter changed the title feat: add C implementation for @stdlib/stats/base/dists/arcsine/median feat: add C implementation for stats/base/dists/arcsine/median Dec 20, 2024
pranav-1720 and others added 5 commits January 13, 2025 16:45
@pranav-1720 @Planeshifter
Update lib/node_modules/@stdlib/stats/base/dists/arcsine/median/READM…
2430fa4 
…E.md

Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: pranav-1720 <[email protected]>
@pranav-1720 @Planeshifter
Update lib/node_modules/@stdlib/stats/base/dists/arcsine/median/READM…
7235adf 
…E.md

Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: pranav-1720 <[email protected]>
@pranav-1720 @Planeshifter
Update lib/node_modules/@stdlib/stats/base/dists/arcsine/median/bench…
f05a010 
…mark/benchmark.native.js

Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: pranav-1720 <[email protected]>
@pranav-1720 @Planeshifter
Update lib/node_modules/@stdlib/stats/base/dists/arcsine/median/inclu…
7dbbbd8 
…de/stdlib/stats/base/dists/arcsine/median.h

Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: pranav-1720 <[email protected]>
@pranav-1720 @Planeshifter
Update lib/node_modules/@stdlib/stats/base/dists/arcsine/median/manif…
6bb60e4 
…est.json

Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: pranav-1720 <[email protected]>
@Planeshifter
Copy link
Member

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 3, 2025
@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. and removed bot: In Progress Pull request is currently awaiting automation. labels Apr 3, 2025
@Planeshifter
chore: apply suggestions from code review
5e2ef17 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
chore: add missing metadata and fix formatting
313be45 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
Planeshifter
Planeshifter approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pranav-1720! Made a few edits but will merge once all CI checks are confirmed as green.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Apr 3, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Apr 3, 2025
@Planeshifter Planeshifter merged commit c487a89 into stdlib-js:develop Apr 3, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pranav-1720 @stdlib-bot @Planeshifter