Skip to content

refactor: update math/base/assert/is-even to follow latest project conventions #4183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 3, 2025
Merged

refactor: update math/base/assert/is-even to follow latest project conventions #4183

merged 9 commits into from
Jan 3, 2025

Conversation

vivekmaurya001
Copy link
Contributor

Resolves None.

Description

  • refactoring addon.c to follow latest project conventions for math/base/assert/is-even
  • updating benchmark calculations

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Dec 23, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 23, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/base/assert/is-even $\color{green}157/157$
$\color{green}+100.00\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}157/157$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@vivekmaurya001
Copy link
Contributor Author

good afternoon, please give this a reveiw @kgryte!

kgryte
kgryte requested changes Jan 2, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left an initial round of comments.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jan 2, 2025
vivekmaurya001 and others added 3 commits January 3, 2025 06:46
@vivekmaurya001
refactor: update math/base/assert/is-even to follow latest project co…
4484477 
…nventions
@vivekmaurya001
Merge branch 'stdlib-js:develop' into math/is-even
0953f0e
@vivekmaurya001
refactor: update math/base/assert/is-even to follow latest project co…
ed70d8c 
…nventions

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
---
kgryte
kgryte approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Jan 3, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

refactor: update `math/base/assert/is-even` to follow latest project conventions

PR-URL: https://github.com/stdlib-js/stdlib/pull/4183

Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Vivek Maurya <[email protected]>
Co-authored-by: Vivek maurya <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Athan <[email protected]>

Please review the above commit message and make any necessary adjustments.

@kgryte kgryte merged commit 861cd7f into stdlib-js:develop Jan 3, 2025
27 checks passed
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 3, 2025
@vivekmaurya001 @kgryte @Neerajpathak07
refactor: update math/base/assert/is-even to follow latest project …
d4e3a94 
…conventions

PR-URL: stdlib-js#4183
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
0PrashantYadav0 pushed a commit to 0PrashantYadav0/stdlib that referenced this pull request Jan 9, 2025
@vivekmaurya001 @kgryte @0PrashantYadav0
refactor: update math/base/assert/is-even to follow latest project …
8895a52 
…conventions

PR-URL: stdlib-js#4183
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 23, 2025
@vivekmaurya001 @kgryte @Neerajpathak07
refactor: update math/base/assert/is-even to follow latest project …
f81a4b5 
…conventions

PR-URL: stdlib-js#4183
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Feb 23, 2025
@vivekmaurya001 @kgryte @Neerajpathak07
refactor: update math/base/assert/is-even to follow latest project …
1a97dfa 
…conventions

PR-URL: stdlib-js#4183
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@vivekmaurya001 @kgryte @ShabiShett07
refactor: update math/base/assert/is-even to follow latest project …
56dfdaa 
…conventions

PR-URL: stdlib-js#4183
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
@vivekmaurya001 vivekmaurya001 mentioned this pull request Mar 26, 2025
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivekmaurya001 @stdlib-bot @kgryte