Skip to content

feat: add math/base/assert/is-probabilityf #4214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jan 11, 2025
Merged

feat: add math/base/assert/is-probabilityf #4214

merged 20 commits into from
Jan 11, 2025

Conversation

vivekmaurya001
Copy link
Contributor

Progresses None

Description

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Dec 25, 2024
@vivekmaurya001
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 25, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 25, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 25, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/base/assert/is-probabilityf $\color{green}147/147$
$\color{green}+100.00\%$ 		$\color{green}6/6$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}147/147$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@vivekmaurya001
Copy link
Contributor Author

@kgryte , please give some reveiw

@kgryte kgryte self-requested a review January 2, 2025 22:20
@vivekmaurya001
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 8, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 8, 2025
@vivekmaurya001 vivekmaurya001 marked this pull request as draft January 8, 2025 07:32
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 8, 2025
@vivekmaurya001 vivekmaurya001 marked this pull request as ready for review January 8, 2025 07:45
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 8, 2025
gunjjoshi
gunjjoshi requested changes Jan 8, 2025
View reviewed changes
@gunjjoshi gunjjoshi added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jan 8, 2025
vivekmaurya001 and others added 5 commits January 8, 2025 22:25
@vivekmaurya001
Merge branch 'stdlib-js:develop' into is_probabilityf
44cb2a6
@vivekmaurya001
add math/base/assert/is-probabilityf
dab8a6a
@vivekmaurya001
add math/base/assert/is-probabilityf
3d09cdb
@vivekmaurya001
add math/base/assert/is-probabilityf
53a8742 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: passed
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---
@vivekmaurya001
add math/base/assert/is-probabilityf
8e9edac
@vivekmaurya001
Copy link
Contributor Author

Good morning , @kgryte please take a look

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jan 11, 2025
@stdlib-bot stdlib-bot removed the Needs Changes Pull request which needs changes before being merged. label Jan 11, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add `math/base/assert/is-probabilityf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4214

Co-authored-by: Gunj Joshi <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Gunj Joshi <[email protected]>
Signed-off-by: Gunj Joshi <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 20b4721 into stdlib-js:develop Jan 11, 2025
29 checks passed
@vivekmaurya001 vivekmaurya001 deleted the is_probabilityf branch January 11, 2025 15:18
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 23, 2025
@vivekmaurya001 @gunjjoshi
@stdlib-bot @Neerajpathak07
feat: add math/base/assert/is-probabilityf
5b9d560 
PR-URL: stdlib-js#4214

Co-authored-by: Gunj Joshi <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Gunj Joshi <[email protected]>
Signed-off-by: Gunj Joshi <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@vivekmaurya001 @gunjjoshi
@stdlib-bot @ShabiShett07
feat: add math/base/assert/is-probabilityf
89be4b7 
PR-URL: stdlib-js#4214

Co-authored-by: Gunj Joshi <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Gunj Joshi <[email protected]>
Signed-off-by: Gunj Joshi <[email protected]>
@vivekmaurya001 vivekmaurya001 mentioned this pull request Mar 26, 2025
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@gunjjoshi gunjjoshi gunjjoshi approved these changes

@kgryte kgryte Awaiting requested review from kgryte

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vivekmaurya001 @stdlib-bot @Planeshifter @gunjjoshi