Skip to content

feat: add C implementation for stats/base/dists/erlang/kurtosis #4289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 3, 2025

Conversation

Neerajpathak07
Copy link
Contributor

Resolves #3570 .

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for stats/base/dists/erlang/kurtosis

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Dec 27, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 27, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/erlang/kurtosis $\color{green}199/199$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}199/199$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review December 27, 2024 13:08
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 27, 2024
@Neerajpathak07 Neerajpathak07 marked this pull request as draft January 16, 2025 16:06
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 16, 2025
@Neerajpathak07
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 17, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 17, 2025
@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review January 17, 2025 19:35
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 17, 2025
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, Neeraj!

For the Erlang packages, it would be good to type the k parameter as a int32_t given the parameter has to be an integer.. This will require some slight refactoring, but hopefully won't be too burdensome.

If people need the larger range afforded by double, they can use the gamma distribution instead.

@Neerajpathak07
Copy link
Contributor Author

@Planeshifter Sure let me get back to you with the refactored code.

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Mar 2, 2025
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good overall; left a few comments that should be addressed. However, I am not sure about the failing test cases right now.

Any ideas on what is going on here, @kgryte?

@Planeshifter
Copy link
Member

/stdlib help

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 7, 2025
@stdlib-bot
Copy link
Contributor

@Planeshifter, available slash commands include:

  • /stdlib check-files - Check for required files.
  • /stdlib update-copyright-years - Update copyright header years.
  • /stdlib lint-autofix - Auto-fix lint errors.
  • /stdlib merge - Merge changes from develop branch into this PR.
  • /stdlib rebase - Rebase this PR on top of develop branch.

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Mar 7, 2025
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR and getting it into great shape, @Neerajpathak07!

As time permits, it would be great to similarly refactor the other Erlang PRs to have an integer-typed k parameter.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Apr 3, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Apr 3, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/erlang/kurtosis`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4289
Closes: https://github.com/stdlib-js/stdlib/issues/3570

Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Neeraj Pathak <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 3e69370 into stdlib-js:develop Apr 3, 2025
30 checks passed
@Neerajpathak07
Copy link
Contributor Author

@Planeshifter Will wrap all of them by tonight. little heads up you'll be pretty attested with some load on reviewing them but dw I'll make sure to bring them in great shape.

@Neerajpathak07 Neerajpathak07 deleted the add-erlang-kurtosis branch April 3, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/erlang/kurtosis
3 participants