Skip to content

feat!: migrate add stats/base/dmeanli to stats/strided/dmeanli #4835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat!: migrate add stats/base/dmeanli to stats/strided/dmeanli #4835

wants to merge 1 commit into from

Conversation

saurabhraghuvanshii
Copy link
Contributor

Resolves #4797.

Description

What is the purpose of this pull request?

This pull request:

  • migrate stats/base/dmeanli to stats/strided/dmeanli

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@saurabhraghuvanshii
feat: add stats/strided/dmeanli and remove base/dmeanli
5745e3f 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 21, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
namespace/alias2pkg $\color{green}95/95$
$\color{green}+100.00\%$ 		$\color{green}7/7$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}95/95$
$\color{green}+100.00\%$
namespace $\color{green}95/95$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}95/95$
$\color{green}+100.00\%$
namespace/pkg2alias $\color{green}100/100$
$\color{green}+100.00\%$ 		$\color{green}10/10$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}100/100$
$\color{green}+100.00\%$
namespace/pkg2related $\color{green}100/100$
$\color{green}+100.00\%$ 		$\color{green}10/10$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}100/100$
$\color{green}+100.00\%$
namespace/pkg2standalone $\color{green}95/95$
$\color{green}+100.00\%$ 		$\color{green}7/7$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}95/95$
$\color{green}+100.00\%$
namespace/standalone2pkg $\color{green}95/95$
$\color{green}+100.00\%$ 		$\color{green}7/7$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}95/95$
$\color{green}+100.00\%$
stats/base $\color{green}1968/1968$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}0/0$
$\color{green}+100.00\%$ 		$\color{green}1968/1968$
$\color{green}+100.00\%$
stats/strided/dmeanli $\color{green}359/359$
$\color{green}+100.00\%$ 		$\color{green}18/18$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}359/359$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented Jan 21, 2025

@saurabhraghuvanshii Thanks for trying your hand at this; however, as mentioned on #4797, we expect an explicit series of commits. Combining actions into a single commit is not what we are wanting, and, as such, this PR cannot be merged as is. I suggest finding and working on other tasks.

@kgryte kgryte closed this Jan 21, 2025
@kgryte kgryte added Invalid Invalid question, issue, or pull request. and removed Needs Review A pull request which needs code review. labels Jan 21, 2025
@kgryte kgryte mentioned this pull request Jan 21, 2025
Closed
1 task
@saurabhraghuvanshii
Copy link
Contributor Author

@kgryte I will try again with series of commits

@saurabhraghuvanshii saurabhraghuvanshii deleted the migrate-dmeanli-1 branch January 21, 2025 19:16
@kgryte
Copy link
Member

kgryte commented Jan 21, 2025

@saurabhraghuvanshii I think it may be better to focus on other tasks. This migration requires various knowledge about the project and which packages are ready to move (not all stats/base packages are!) which only maintainers atm have insight into.

@saurabhraghuvanshii
Copy link
Contributor Author

@kgryte ok sir , thanks for support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Invalid Invalid question, issue, or pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: move strided packages from stats/base/* to stats/strided/*
3 participants
@saurabhraghuvanshii @stdlib-bot @kgryte