Skip to content

bench: refactor random number generation in stats/base/dists/uniform #5027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

bench: refactor random number generation in stats/base/dists/uniform #5027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions lib/node_modules/@stdlib/stats/base/dists/uniform/cdf/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pkg = require( './../package.json' ).name;
var cdf = require( './../lib' );
Expand All @@ -36,11 +36,12 @@ bench( pkg, function benchmark( b ) {
var y;
var i;

x = uniform( -10.0, 10.0 );
min = uniform( -20.0, 0.0 );
max = uniform( min, min + 40.0 );

Comment on lines +39 to +42
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
x = uniform( -10.0, 10.0 );
min = uniform( -20.0, 0.0 );
max = uniform( min, min + 40.0 );
len = 100;
x = new Float64Array( len );
min = new Float64Array( len );
max = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
x[ i ] = uniform( -10.0, 10.0 );
min[ i ] = uniform( -20.0, 0.0 );
max[ i ] = uniform( min[ i ], min[ i ] + 40.0 );
}

This would be the correct way to initialize random values for the variables.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update. This really helps!!!

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = ( randu() * 20.0 ) - 10.0;
min = ( randu() * 20.0 ) - 20.0;
max = min + ( randu() * 40.0 );
y = cdf( x, min, max );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand Down Expand Up @@ -68,7 +69,7 @@ bench( pkg+':factory', function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = ( randu()*2.0 ) - 2.0;
x = uniform( -2.0, 0.0 );
y = mycdf( x );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand Down
36 changes: 18 additions & 18 deletions lib/node_modules/@stdlib/stats/base/dists/uniform/ctor/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var EPS = require( '@stdlib/constants/float64/eps' );
var pkg = require( './../package.json' ).name;
Expand All @@ -38,8 +38,8 @@ bench( pkg+'::instantiation', function benchmark( bm ) {

bm.tic();
for ( i = 0; i < bm.iterations; i++ ) {
a = ( randu() * 10.0 ) + EPS;
b = ( randu() * 10.0 ) + a + EPS;
a = uniform( EPS, EPS + 10.0 );
b = uniform( a + EPS, a + EPS + 10.0 );
dist = new Uniform( a, b );
if ( !( dist instanceof Uniform ) ) {
bm.fail( 'should return a distribution instance' );
Expand Down Expand Up @@ -92,7 +92,7 @@ bench( pkg+'::set:a', function benchmark( bm ) {

bm.tic();
for ( i = 0; i < bm.iterations; i++ ) {
y = ( 100.0*randu() ) + EPS;
y = uniform( EPS, EPS + 100.0 );
dist.a = y;
if ( dist.a !== y ) {
bm.fail( 'should return set value' );
Expand Down Expand Up @@ -145,7 +145,7 @@ bench( pkg+'::set:b', function benchmark( bm ) {

bm.tic();
for ( i = 0; i < bm.iterations; i++ ) {
y = ( 100.0*randu() ) + a + EPS;
y = uniform( a + EPS, a + EPS + 100.0 );
dist.b = y;
if ( dist.b !== y ) {
bm.fail( 'should return set value' );
Expand All @@ -172,7 +172,7 @@ bench( pkg+':entropy', function benchmark( bm ) {

bm.tic();
for ( i = 0; i < bm.iterations; i++ ) {
dist.a = ( 100.0*randu() ) + EPS;
dist.a = uniform( EPS, EPS + 100.0 );
y = dist.entropy;
if ( isnan( y ) ) {
bm.fail( 'should not return NaN' );
Expand All @@ -199,7 +199,7 @@ bench( pkg+':kurtosis', function benchmark( bm ) {

bm.tic();
for ( i = 0; i < bm.iterations; i++ ) {
dist.a = ( 100.0*randu() ) + EPS;
dist.a = uniform( EPS, EPS + 100.0 );
y = dist.kurtosis;
if ( isnan( y ) ) {
bm.fail( 'should not return NaN' );
Expand All @@ -226,7 +226,7 @@ bench( pkg+':mean', function benchmark( bm ) {

bm.tic();
for ( i = 0; i < bm.iterations; i++ ) {
dist.a = ( 100.0*randu() ) + EPS;
dist.a = uniform( EPS, EPS + 100.0 );
y = dist.mean;
if ( isnan( y ) ) {
bm.fail( 'should not return NaN' );
Expand All @@ -253,7 +253,7 @@ bench( pkg+':median', function benchmark( bm ) {

bm.tic();
for ( i = 0; i < bm.iterations; i++ ) {
dist.a = ( 100.0*randu() ) + EPS;
dist.a = uniform( EPS, EPS + 100.0 );
y = dist.median;
if ( isnan( y ) ) {
bm.fail( 'should not return NaN' );
Expand All @@ -280,7 +280,7 @@ bench( pkg+':skewness', function benchmark( bm ) {

bm.tic();
for ( i = 0; i < bm.iterations; i++ ) {
dist.a = ( 100.0*randu() ) + EPS;
dist.a = uniform( EPS, EPS + 100.0 );
y = dist.skewness;
if ( isnan( y ) ) {
bm.fail( 'should not return NaN' );
Expand All @@ -307,7 +307,7 @@ bench( pkg+':stdev', function benchmark( bm ) {

bm.tic();
for ( i = 0; i < bm.iterations; i++ ) {
dist.a = ( 100.0*randu() ) + EPS;
dist.a = uniform( EPS, EPS + 100.0 );
y = dist.stdev;
if ( isnan( y ) ) {
bm.fail( 'should not return NaN' );
Expand All @@ -334,7 +334,7 @@ bench( pkg+':variance', function benchmark( bm ) {

bm.tic();
for ( i = 0; i < bm.iterations; i++ ) {
dist.a = ( 100.0*randu() ) + EPS;
dist.a = uniform( EPS, EPS + 100.0 );
y = dist.variance;
if ( isnan( y ) ) {
bm.fail( 'should not return NaN' );
Expand Down Expand Up @@ -362,7 +362,7 @@ bench( pkg+':cdf', function benchmark( bm ) {

bm.tic();
for ( i = 0; i < bm.iterations; i++ ) {
x = randu() * 60.0;
x = uniform( 0.0, 60.0 );
y = dist.cdf( x );
if ( isnan( y ) ) {
bm.fail( 'should not return NaN' );
Expand Down Expand Up @@ -390,7 +390,7 @@ bench( pkg+':logcdf', function benchmark( bm ) {

bm.tic();
for ( i = 0; i < bm.iterations; i++ ) {
x = randu() * 60.0;
x = uniform( 0.0, 60.0 );
y = dist.logcdf( x );
if ( isnan( y ) ) {
bm.fail( 'should not return NaN' );
Expand Down Expand Up @@ -418,7 +418,7 @@ bench( pkg+':logpdf', function benchmark( bm ) {

bm.tic();
for ( i = 0; i < bm.iterations; i++ ) {
x = randu() * 60.0;
x = uniform( 0.0, 60.0 );
y = dist.logpdf( x );
if ( isnan( y ) ) {
bm.fail( 'should not return NaN' );
Expand Down Expand Up @@ -446,7 +446,7 @@ bench( pkg+':mgf', function benchmark( bm ) {

bm.tic();
for ( i = 0; i < bm.iterations; i++ ) {
x = randu();
x = uniform( 0.0, 1.0 );
y = dist.mgf( x );
if ( isnan( y ) ) {
bm.fail( 'should not return NaN' );
Expand Down Expand Up @@ -474,7 +474,7 @@ bench( pkg+':pdf', function benchmark( bm ) {

bm.tic();
for ( i = 0; i < bm.iterations; i++ ) {
x = randu() * 60.0;
x = uniform( 0.0, 60.0 );
y = dist.pdf( x );
if ( isnan( y ) ) {
bm.fail( 'should not return NaN' );
Expand Down Expand Up @@ -502,7 +502,7 @@ bench( pkg+':quantile', function benchmark( bm ) {

bm.tic();
for ( i = 0; i < bm.iterations; i++ ) {
x = randu();
x = uniform( 0.0, 1.0 );
y = dist.quantile( x );
if ( isnan( y ) ) {
bm.fail( 'should not return NaN' );
Expand Down
6 changes: 3 additions & 3 deletions lib/node_modules/@stdlib/stats/base/dists/uniform/entropy/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

var bench = require( '@stdlib/bench' );
var Float64Array = require( '@stdlib/array/float64' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pkg = require( './../package.json' ).name;
var entropy = require( './../lib' );
Expand All @@ -41,8 +41,8 @@ bench( pkg, function benchmark( b ) {
min = new Float64Array( len );
max = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
min[ i ] = ( randu()*10.0 );
max[ i ] = ( randu()*10.0 ) + min[ i ];
min[ i ] = uniform( 0.0, 10.0 );
max[ i ] = uniform( min[ i ], min[ i ] + 10.0 );
}

b.tic();
Expand Down
6 changes: 3 additions & 3 deletions lib/node_modules/@stdlib/stats/base/dists/uniform/entropy/benchmark/benchmark.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ var resolve = require( 'path' ).resolve;
var bench = require( '@stdlib/bench' );
var Float64Array = require( '@stdlib/array/float64' );
var tryRequire = require( '@stdlib/utils/try-require' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pkg = require( './../package.json' ).name;

Expand All @@ -50,8 +50,8 @@ bench( pkg+'::native', opts, function benchmark( b ) {
min = new Float64Array( len );
max = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
min[ i ] = ( randu()*10.0 );
max[ i ] = ( randu()*10.0 ) + min[ i ];
min[ i ] = uniform( 0.0, 10.0 );
max[ i ] = uniform( min[ i ], min[ i ] + 10.0 );
}

b.tic();
Expand Down
6 changes: 3 additions & 3 deletions lib/node_modules/@stdlib/stats/base/dists/uniform/kurtosis/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pkg = require( './../package.json' ).name;
var kurtosis = require( './../lib' );
Expand All @@ -37,8 +37,8 @@ bench( pkg, function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
min = ( randu()*10.0 );
max = ( randu()*10.0 ) + min;
min = uniform( 0.0, 10.0 );
max = uniform( min, min + 10.0 );
y = kurtosis( min, max );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand Down
10 changes: 5 additions & 5 deletions lib/node_modules/@stdlib/stats/base/dists/uniform/logcdf/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pkg = require( './../package.json' ).name;
var logcdf = require( './../lib' );
Expand All @@ -38,9 +38,9 @@ bench( pkg, function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = ( randu() * 20.0 ) - 10.0;
min = ( randu() * 20.0 ) - 20.0;
max = min + ( randu() * 40.0 );
x = uniform( -10.0, 10.0 );
min = uniform( -20.0, 0.0 );
max = uniform( min, min + 40.0 );
y = logcdf( x, min, max );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand Down Expand Up @@ -68,7 +68,7 @@ bench( pkg+':factory', function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = ( randu()*2.0 ) - 2.0;
x = uniform( -2.0, 0.0 );
y = mylogcdf( x );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand Down
10 changes: 5 additions & 5 deletions lib/node_modules/@stdlib/stats/base/dists/uniform/logpdf/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pkg = require( './../package.json' ).name;
var logpdf = require( './../lib' );
Expand All @@ -38,9 +38,9 @@ bench( pkg, function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = ( randu() * 20.0 ) - 10.0;
min = ( randu() * 20.0 ) - 20.0;
max = min + ( randu() * 40.0 );
x = uniform( -10.0, 10.0 );
min = uniform( -20.0, 0.0 );
max = uniform( min, min + 40.0 );
y = logpdf( x, min, max );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand Down Expand Up @@ -68,7 +68,7 @@ bench( pkg+':factory', function benchmark( b ) {

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = ( randu()*2.0 ) - 2.0;
x = uniform( -2.0, 0.0 );
y = mylogpdf( x );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
Expand Down
6 changes: 3 additions & 3 deletions lib/node_modules/@stdlib/stats/base/dists/uniform/mean/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var Float64Array = require( '@stdlib/array/float64' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pkg = require( './../package.json' ).name;
Expand All @@ -42,8 +42,8 @@ bench( pkg, function benchmark( b ) {
bval = new Float64Array( len );

for ( i = 0; i < len; i++ ) {
a[ i ] = randu() * 100.0;
bval[ i ] = a[ i ] + ( randu() * 50.0 );
a[ i ] = uniform( 0.0, 100.0 );
bval[ i ] = uniform( a[ i ], a[ i ] + 50.0 );
}

b.tic();
Expand Down
6 changes: 3 additions & 3 deletions lib/node_modules/@stdlib/stats/base/dists/uniform/mean/benchmark/benchmark.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
var resolve = require( 'path' ).resolve;
var bench = require( '@stdlib/bench' );
var Float64Array = require( '@stdlib/array/float64' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var tryRequire = require( '@stdlib/utils/try-require' );
var pkg = require( './../package.json' ).name;
Expand All @@ -50,8 +50,8 @@ bench( pkg+'::native', opts, function benchmark( b ) {
a = new Float64Array( len );
bnd = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
a[ i ] = randu() * 100.0;
bnd[ i ] = a[ i ] + ( randu() * 100.0 );
a[ i ] = uniform( 0.0, 100.0 );
bnd[ i ] = uniform( a[ i ], a[ i ] + 100.0 );
}

b.tic();
Expand Down
6 changes: 3 additions & 3 deletions lib/node_modules/@stdlib/stats/base/dists/uniform/median/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var Float64Array = require( '@stdlib/array/float64' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pkg = require( './../package.json' ).name;
Expand All @@ -42,8 +42,8 @@ bench( pkg, function benchmark( b ) {
bnd = new Float64Array( len );

for ( i = 0; i < len; i++ ) {
a[ i ] = randu() * 100.0;
bnd[ i ] = a[ i ] + ( randu() * 50.0 );
a[ i ] = uniform( 0.0, 100.0 );
bnd[ i ] = uniform( a[ i ], a[ i ] + 50.0 );
}

b.tic();
Expand Down
6 changes: 3 additions & 3 deletions lib/node_modules/@stdlib/stats/base/dists/uniform/median/benchmark/benchmark.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
var resolve = require( 'path' ).resolve;
var bench = require( '@stdlib/bench' );
var Float64Array = require( '@stdlib/array/float64' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var tryRequire = require( '@stdlib/utils/try-require' );
var pkg = require( './../package.json' ).name;
Expand All @@ -50,8 +50,8 @@ bench( pkg+'::native', opts, function benchmark( b ) {
a = new Float64Array( len );
bnd = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
a[ i ] = randu() * 100.0;
bnd[ i ] = a[ i ] + ( randu() * 100.0 );
a[ i ] = uniform( 0.0, 100.0 );
bnd[ i ] = uniform( a[ i ], a[ i ] + 100.0 );
}

b.tic();
Expand Down
Loading