Skip to content

docs: fix require paths and add missing semicolon #5055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

MohammadBinAftab
Copy link
Contributor

@MohammadBinAftab MohammadBinAftab commented Feb 4, 2025

Hey there, Maintainers!
I have fixed issue #5052 as described in the issue desciption. I hope this resolves the issue.

@stdlib-bot stdlib-bot added LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Feb 4, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
lapack/base/claset $\color{green}1113/1113$
$\color{green}+100.00\%$
$\color{green}41/41$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}1113/1113$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@MohammadBinAftab MohammadBinAftab marked this pull request as draft February 4, 2025 10:08
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 4, 2025
@kgryte
Copy link
Member

kgryte commented Feb 4, 2025

@MohammadBinAftab Thanks for submitting this PR. Would you mind doing what the comment above asks (see #5055 (comment))? Namely, adding to your OP the checkbox with the acknowledgment. Cheers!

@MohammadBinAftab MohammadBinAftab marked this pull request as ready for review February 4, 2025 10:14
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 4, 2025
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Planeshifter Planeshifter changed the title fixed the issue #5052 docs: fix require paths and add missing semicolon Feb 4, 2025
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Feb 4, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 4, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

docs: fix require paths and add missing semicolon

PR-URL: https://github.com/stdlib-js/stdlib/pull/5055
Ref: https://github.com/stdlib-js/stdlib/issues/5052

Co-authored-by: Mohammadbinaftab <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 28597c6 into stdlib-js:develop Feb 4, 2025
91 of 93 checks passed
@kgryte kgryte added the Documentation Improvements, additions, or changes to documentation. label Feb 4, 2025
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Feb 11, 2025
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements, additions, or changes to documentation. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants