-
-
Notifications
You must be signed in to change notification settings - Fork 805
docs: fix require paths and add missing semicolon #5055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
Coverage Report
The above coverage report was generated for the changes in this PR. |
@MohammadBinAftab Thanks for submitting this PR. Would you mind doing what the comment above asks (see #5055 (comment))? Namely, adding to your OP the checkbox with the acknowledgment. Cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
PR Commit Message
Please review the above commit message and make any necessary adjustments. |
PR-URL: stdlib-js#5055 Closes: stdlib-js#5052 Reviewed-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#5055 Closes: stdlib-js#5052 Reviewed-by: Philipp Burckhardt <[email protected]>
Hey there, Maintainers!
I have fixed issue #5052 as described in the issue desciption. I hope this resolves the issue.