bench: refactor random number generation in stats/base/dists/lognormal

[saurabhraghuvanshii]

Resolves #4979

Description

What is the purpose of this pull request?

This pull request:

• refractor random number generation in lognormal/benchmarks.js files

Related Issues

Does this pull request have any related issues?

This pull request:

• resolves [RFC]: Refactor random number generation in JS benchmarks for stats/base/dists/lognormal #4979

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines.

---

@stdlib-js/reviewers

[stdlib-bot]

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/lognormal/cdf	$\color{green}212/212$ $\color{green}+100.00\%$	$\color{green}21/21$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}212/212$ $\color{green}+100.00\%$
stats/base/dists/lognormal/ctor	$\color{green}458/458$ $\color{green}+100.00\%$	$\color{green}35/35$ $\color{green}+100.00\%$	$\color{green}18/18$ $\color{green}+100.00\%$	$\color{green}458/458$ $\color{green}+100.00\%$
stats/base/dists/lognormal/entropy	$\color{green}115/115$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}115/115$ $\color{green}+100.00\%$
stats/base/dists/lognormal/kurtosis	$\color{green}120/120$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}120/120$ $\color{green}+100.00\%$
stats/base/dists/lognormal/logcdf	$\color{green}212/212$ $\color{green}+100.00\%$	$\color{green}16/16$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}212/212$ $\color{green}+100.00\%$
stats/base/dists/lognormal/logpdf	$\color{green}246/246$ $\color{green}+100.00\%$	$\color{green}21/21$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}246/246$ $\color{green}+100.00\%$
stats/base/dists/lognormal/mean	$\color{green}113/113$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}113/113$ $\color{green}+100.00\%$
stats/base/dists/lognormal/median	$\color{green}113/113$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}113/113$ $\color{green}+100.00\%$
stats/base/dists/lognormal/mode	$\color{green}113/113$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}113/113$ $\color{green}+100.00\%$
stats/base/dists/lognormal/pdf	$\color{green}248/248$ $\color{green}+100.00\%$	$\color{green}21/21$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}248/248$ $\color{green}+100.00\%$
stats/base/dists/lognormal/quantile	$\color{green}224/224$ $\color{green}+100.00\%$	$\color{green}21/21$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}224/224$ $\color{green}+100.00\%$
stats/base/dists/lognormal/skewness	$\color{green}116/116$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}116/116$ $\color{green}+100.00\%$
stats/base/dists/lognormal/stdev	$\color{green}116/116$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}116/116$ $\color{green}+100.00\%$
stats/base/dists/lognormal/variance	$\color{green}178/178$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}178/178$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

[anandkaranubc]

Thanks, @saurabhraghuvanshii, for working on this. An important aspect of this PR is also to move the random number generation outside the benchmarking loops, which is still pending in this PR. The reference issues will be helpful for understanding this change.

[saurabhraghuvanshii]

I don't do that because in C implementation PRs they already done it. so there fore I don't do that

[saurabhraghuvanshii]

I just do for now until that PRs can't be merged

[anandkaranubc]

I don't do that because in C implementation PRs they already done it. so there fore I don't do that

If you are waiting for those PRs to be merged before this, you can keep this as a draft.

[saurabhraghuvanshii]

ok I will do changes

[saurabhraghuvanshii]

@anandkaranubc done you can check .

[anandkaranubc]

@anandkaranubc done you can check .

On it!

[anandkaranubc]

Just some minor changes. Rest, the PR looks good! Thanks!

[Planeshifter]

Let's get it in. 🚀

[stdlib-bot]

PR Commit Message

bench: refactor random number generation in `stats/base/dists/lognormal`

PR-URL: https://github.com/stdlib-js/stdlib/pull/5164
Closes: https://github.com/stdlib-js/stdlib/issues/4979

Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: saurabhraghuvanshii <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.