bench: refactor random number generation in stats/base/dists/triangular

[G4URAV001]

… in JS benchmarks

Resolves #4989 .

Description

What is the purpose of this pull request?

This pull request:

• This pull request improves random number generation in JS benchmarks for stats/base/dists/triangular. Specifically:

• Moves random number generation out of benchmarking loops to prevent interference with benchmark results.

• Uses @stdlib/random/base/uniform and @stdlib/random/base/discrete-uniform instead of randu expressions.

• Ensures generated random values maintain the same range as existing values for consistency.

Related Issues

Does this pull request have any related issues?

This pull request:

• Resolves [RFC]: Refactor random number generation in JS benchmarks for stats/base/dists/triangular #4989
• References bench: refactor random number generation in stats/base/dists/beta #4837 and bench: refactor random number generation in stats/base/dists/hypergeometric #4955 as examples of similar improvements.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines

✅ Build Native Add-on.
✅ Run JavaScript Benchmarks.
✅ Run JavaScript Native Benchmarks.

---

@stdlib-js/reviewers

[stdlib-bot]

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

1. Please read our contributing guidelines.

2. Update your pull request description to include this checked box:

   - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

• The developer's certificate of origin
• Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

[stdlib-bot]

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/triangular/cdf	$\color{green}271/271$ $\color{green}+100.00\%$	$\color{green}34/34$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}271/271$ $\color{green}+100.00\%$
stats/base/dists/triangular/ctor	$\color{green}524/524$ $\color{green}+100.00\%$	$\color{green}58/58$ $\color{green}+100.00\%$	$\color{green}21/21$ $\color{green}+100.00\%$	$\color{green}524/524$ $\color{green}+100.00\%$
stats/base/dists/triangular/entropy	$\color{green}206/206$ $\color{green}+100.00\%$	$\color{green}11/11$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}206/206$ $\color{green}+100.00\%$
stats/base/dists/triangular/kurtosis	$\color{green}205/205$ $\color{green}+100.00\%$	$\color{green}11/11$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}205/205$ $\color{green}+100.00\%$
stats/base/dists/triangular/logcdf	$\color{green}356/356$ $\color{green}+100.00\%$	$\color{green}36/36$ $\color{green}+100.00\%$	$\color{green}4/4$ $\color{green}+100.00\%$	$\color{green}356/356$ $\color{green}+100.00\%$
stats/base/dists/triangular/logpdf	$\color{green}362/362$ $\color{green}+100.00\%$	$\color{green}39/39$ $\color{green}+100.00\%$	$\color{green}4/4$ $\color{green}+100.00\%$	$\color{green}362/362$ $\color{green}+100.00\%$
stats/base/dists/triangular/mean	$\color{green}189/189$ $\color{green}+100.00\%$	$\color{green}11/11$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}189/189$ $\color{green}+100.00\%$
stats/base/dists/triangular/median	$\color{green}197/197$ $\color{green}+100.00\%$	$\color{green}12/12$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}197/197$ $\color{green}+100.00\%$
stats/base/dists/triangular/mgf	$\color{green}380/380$ $\color{green}+100.00\%$	$\color{green}38/38$ $\color{green}+100.00\%$	$\color{green}5/5$ $\color{green}+100.00\%$	$\color{green}380/380$ $\color{green}+100.00\%$
stats/base/dists/triangular/mode	$\color{green}189/189$ $\color{green}+100.00\%$	$\color{green}11/11$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}189/189$ $\color{green}+100.00\%$
stats/base/dists/triangular/pdf	$\color{green}348/348$ $\color{green}+100.00\%$	$\color{green}39/39$ $\color{green}+100.00\%$	$\color{green}4/4$ $\color{green}+100.00\%$	$\color{green}348/348$ $\color{green}+100.00\%$
stats/base/dists/triangular/quantile	$\color{green}356/356$ $\color{green}+100.00\%$	$\color{green}35/35$ $\color{green}+100.00\%$	$\color{green}4/4$ $\color{green}+100.00\%$	$\color{green}356/356$ $\color{green}+100.00\%$
stats/base/dists/triangular/skewness	$\color{green}210/210$ $\color{green}+100.00\%$	$\color{green}11/11$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}210/210$ $\color{green}+100.00\%$
stats/base/dists/triangular/stdev	$\color{green}206/206$ $\color{green}+100.00\%$	$\color{green}11/11$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}206/206$ $\color{green}+100.00\%$
stats/base/dists/triangular/variance	$\color{green}197/197$ $\color{green}+100.00\%$	$\color{green}11/11$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}197/197$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

[G4URAV001]

i have added the following which stdlib-bot pointed out
"- [x] Read, understood, and followed the contributing guidelines"

[Neerajpathak07]

i have added the following which stdlib-bot pointed out "- [x] Read, understood, and followed the contributing guidelines"

Hey, Could you pls add a space after the hyphen Ig that's what's causing the error.

[G4URAV001]

i have added the following which stdlib-bot pointed out "- [x] Read, understood, and followed the contributing guidelines"

hey, Could you pls add a space after the hyphen Ig that's what's causing the error.

I think it was for the main PR. i didn't had there initially, i added it now. there

[Neerajpathak07]

Apparently the CI errors is specific to the current PR and not affected by other ones. I suppose the change should be made here.

[G4URAV001]

Apparently the CI errors is specific to the current PR and not affected by other ones. I suppose the change should be made h

ya i think i made it now in current PR. It should work now

[G4URAV001]

@anandkaranubc Can you review the PR now ?

[anandkaranubc]

@anandkaranubc Can you review the PR now ?

On it!

[anandkaranubc]

@G4URAV001 Can you also update the title to:

bench: refactor random number generation in JS benchmarks for stats/base/dists/triangular

which is just adding backticks around stats/base/dists/triangular

[G4URAV001]

@anandkaranubc Did the changes, please review this

[anandkaranubc]

@anandkaranubc Did the changes, please review this

On it!

[anandkaranubc]

One small change. Rest, everything looks good! Thanks!

[Neerajpathak07]

Not something related to this PR But,
I think we should achieve 100% code coverage for the following packages ctor,median and mgf.
@anandkaranubc @kgryte what do you guys think!!

[kgryte]

@Neerajpathak07 Agreed. Feel free to submit separate PRs for addressing any gaps in coverage.

[G4URAV001]

@anandkaranubc hey please review it I think I made all the corrections

[G4URAV001]

Had some bugs in last commit