Skip to content

chore: fix EditorConfig lint errors #5516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

chore: fix EditorConfig lint errors #5516

wants to merge 7 commits into from
+116 −257

Conversation

jalajk3004
Copy link
Contributor

Resolves #5453

Description

What is the purpose of this pull request?

This pull request:

  1. It corrects the indentation of lib/node_modules/@stdlib/ndarray/base/assert/is-allowed-data-type-cast/manifest.json
  2. It corrects the indentation of lib/node_modules/@stdlib/ndarray/safe-casts/manifest.json
  3. It corrects the indentation of lib/node_modules/@stdlib/number/float64/base/signbit/manifest.json
  • {{TODO: add description describing what this pull request does}}

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@jalajk3004
fixed linting error: removed the cinstructor
08b0f9e 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@jalajk3004
fixed linting error
74aa861 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: passed
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: failed
---
@jalajk3004
fixed the indented space in manifest.json
cb66756 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Feb 28, 2025
@jalajk3004
correct indent
45138be 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@jalajk3004
uses space instead of tab
7f99836 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
Neerajpathak07
Neerajpathak07 reviewed Feb 28, 2025
View reviewed changes
lib/node_modules/@stdlib/_tools/github/get/lib/cache.js Outdated
@@ -28,10 +28,13 @@
* @returns {Array} cache
*/
function create( size ) {
return new Array( size );
const cache = [];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jalajk3004,
I believe the issue only meant to have changes in the manifest files. That too because they were supposed to be space intended.
Would primarily be the reason causing error.

Neerajpathak07
Neerajpathak07 reviewed Feb 28, 2025
View reviewed changes
lib/node_modules/@stdlib/_tools/pkgs/browser-entry-points/lib/sync.js Outdated
@@ -55,7 +55,7 @@ var debug = logger( 'browser-entry-points:sync' );
* var pkgs = [ '/foo/bar/baz' ];
*
* var entries = entryPoints( pkgs );
* // returns [{...}]
* // throws <Error>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment.

Neerajpathak07
Neerajpathak07 reviewed Feb 28, 2025
View reviewed changes
lib/node_modules/@stdlib/ndarray/base/assert/is-allowed-data-type-cast/manifest.json
]
}
]
"options": {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these indentations are right should be 2 spaces take a look at this
for reference.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed this should be two-space indentation here and in the other JSON files changed in this PR.

@Neerajpathak07
Copy link
Contributor

Could you pls change the PR tittle to:-
chore: fix EditorConfig lint errors
As we reference the issue in the description of the PR so there would be no need to add it in the tittle.

@jalajk3004 jalajk3004 changed the title chore: fix EditorConfig lint errors #5453 chore: fix EditorConfig lint errors Feb 28, 2025
@Neerajpathak07 Neerajpathak07 mentioned this pull request Feb 28, 2025
Closed
1 task
kgryte
kgryte reviewed Mar 1, 2025
View reviewed changes
lib/node_modules/@stdlib/_tools/github/get/lib/cache.js Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to this file should be reverted.

kgryte
kgryte reviewed Mar 1, 2025
View reviewed changes
lib/node_modules/@stdlib/_tools/pkgs/browser-entry-points/lib/sync.js Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to this file should be reverted.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 1, 2025
@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Mar 2, 2025
@Planeshifter Planeshifter added the Potential Duplicate There might be another pull request resolving the same issue. label Mar 15, 2025
@jalajk3004 jalajk3004 mentioned this pull request Mar 29, 2025
Open
7 tasks
@Planeshifter Planeshifter added autoclose: Project Conventions Pull request which should be auto-closed due to not following project conventions. and removed autoclose: Project Conventions Pull request which should be auto-closed due to not following project conventions. labels Mar 29, 2025
@Planeshifter
Copy link
Member

Files shouldn't have been deleted in this PR. Also, any JSON files should use 2-space indentation instead of four spaces. Feel free to create another, clean PR, as this would be easier than cleaning up this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte left review comments

@Neerajpathak07 Neerajpathak07 Neerajpathak07 left review comments

Assignees
No one assigned
Labels
Good First PR A pull request resolving a Good First Issue. Needs Changes Pull request which needs changes before being merged. Potential Duplicate There might be another pull request resolving the same issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix EditorConfig lint errors
5 participants
@jalajk3004 @Neerajpathak07 @Planeshifter @kgryte @stdlib-bot