feat: add `math/base/special/sincosd` #5837

anandkaranubc · 2025-03-07T01:48:19Z

Resolves None

Description

What is the purpose of this pull request?

This pull request:

Adds the JS and C implementation of the function to compute the sincos of x, where x is in degrees.

Related Issues

Does this pull request have any related issues?

This pull request:

resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

anandkaranubc · 2025-03-07T01:49:52Z

Reference implementation

stdlib-bot · 2025-03-07T01:50:38Z

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/sincosd	$\color{green}249/249$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}249/249$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

anandkaranubc · 2025-03-07T01:51:52Z

Also, the cephes and built-in math benchmarks have been removed because there is no implementation of sincosd in those libraries.

lib/node_modules/@stdlib/math/base/special/sincosd/README.md

lib/node_modules/@stdlib/math/base/special/sincosd/lib/main.js

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

gunjjoshi · 2025-03-07T18:17:44Z

lib/node_modules/@stdlib/math/base/special/sincosd/docs/repl.txt

+    [ NaN, NaN ]
+
+
+{{alias}}( x, out, stride, offset )


Suggested change

{{alias}}( x, out, stride, offset )

{{alias}}.assign( x, out, stride, offset )

gunjjoshi · 2025-03-07T18:31:50Z

lib/node_modules/@stdlib/math/base/special/sincosd/lib/index.js

+*
+* var out = new Float64Array( 2 );
+*
+* var v = sincosd( out, 0.0 );


Suggested change

* var v = sincosd( out, 0.0 );

* var v = sincosd.assign( 0.0, out, 1, 0 );

lib/node_modules/@stdlib/math/base/special/sincosd/src/main.c

gunjjoshi · 2025-03-07T18:40:37Z

lib/node_modules/@stdlib/math/base/special/sincosd/test/test.assign.js

+	z = [ 0.0, 0.0 ];
+	v = sincosd( NaN, z, 1, 0 );
+	t.equal( v, z, 'returns output array' );
+	t.equal( isnan( v[0] ), true, 'returns NaN' );


Suggested change

t.equal( isnan( v[0] ), true, 'returns NaN' );

t.equal( isnan( v[0] ), true, 'returns expected value' );

@anandkaranubc Can you change this everywhere else in this file and in other test files too, if applicable?

Sure! On it right away! Thanks.

gunjjoshi · 2025-03-07T18:43:43Z

lib/node_modules/@stdlib/math/base/special/sincosd/package.json

+{
+  "name": "@stdlib/math/base/special/sincosd",
+  "version": "0.0.0",
+  "description": "Simultaneously compute the sine and cosine an angle measured in degrees.",


Suggested change

"description": "Simultaneously compute the sine and cosine an angle measured in degrees.",

"description": "Simultaneously compute the sine and cosine of an angle measured in degrees.",

gunjjoshi · 2025-03-07T18:44:30Z

lib/node_modules/@stdlib/math/base/special/sincosd/README.md

+
+# sincosd
+
+> Simultaneously compute the [sine][@stdlib/math/base/special/sind] and [cosine][@stdlib/math/base/special/cosd] an angle measured in degrees.


Suggested change

> Simultaneously compute the [sine][@stdlib/math/base/special/sind] and [cosine][@stdlib/math/base/special/cosd] an angle measured in degrees.

> Simultaneously compute the [sine][@stdlib/math/base/special/sind] and [cosine][@stdlib/math/base/special/cosd] of an angle measured in degrees.

Oh sorry, that's my fault. I will change it in all the files.

gunjjoshi · 2025-03-07T18:45:27Z

lib/node_modules/@stdlib/math/base/special/sincosd/README.md

+
+#### sincosd( x )
+
+Simultaneously computes the [sine][@stdlib/math/base/special/sind] and [cosine][@stdlib/math/base/special/cosd] of a `number` (in degrees).


Suggested change

Simultaneously computes the [sine][@stdlib/math/base/special/sind] and [cosine][@stdlib/math/base/special/cosd] of a `number` (in degrees).

Simultaneously computes the [sine][@stdlib/math/base/special/sind] and [cosine][@stdlib/math/base/special/cosd] of an `angle` measured in degrees.

gunjjoshi · 2025-03-07T18:46:21Z

lib/node_modules/@stdlib/math/base/special/sincosd/README.md

+
+#### sincosd.assign( x, out, stride, offset )
+
+Simultaneously computes the [sine][@stdlib/math/base/special/sind] and [cosine][@stdlib/math/base/special/cosd] of a `number` (in degrees) and assigns results to a provided output array.


Suggested change

Simultaneously computes the [sine][@stdlib/math/base/special/sind] and [cosine][@stdlib/math/base/special/cosd] of a `number` (in degrees) and assigns results to a provided output array.

Simultaneously computes the [sine][@stdlib/math/base/special/sind] and [cosine][@stdlib/math/base/special/cosd] of an `angle` measured in degrees and assigns results to a provided output array.

gunjjoshi · 2025-03-07T18:46:48Z

lib/node_modules/@stdlib/math/base/special/sincosd/README.md

+
+#### stdlib_base_sincosd( x, &sine, &cosine )
+
+Simultaneously computes the [sine][@stdlib/math/base/special/sind] and [cosine][@stdlib/math/base/special/cosd] of a `number` (in degrees).


Suggested change

Simultaneously computes the [sine][@stdlib/math/base/special/sind] and [cosine][@stdlib/math/base/special/cosd] of a `number` (in degrees).

Simultaneously computes the [sine][@stdlib/math/base/special/sind] and [cosine][@stdlib/math/base/special/cosd] of an `angle` measured in degrees.

lib/node_modules/@stdlib/math/base/special/sincosd/README.md

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

lib/node_modules/@stdlib/math/base/special/sincosd/README.md

Signed-off-by: Gunj Joshi <[email protected]>

lib/node_modules/@stdlib/math/base/special/sincosd/docs/repl.txt

Signed-off-by: Gunj Joshi <[email protected]>

gunjjoshi · 2025-03-07T19:16:36Z

Thanks for working on this, @anandkaranubc!

anandkaranubc · 2025-03-07T19:19:24Z

Thanks for working on this, @anandkaranubc!

@gunjjoshi, big thanks to you as well for your review and feedback! Appreciate it! 🙌

stdlib-bot · 2025-03-07T22:44:24Z

PR Commit Message

feat: add `math/base/special/sincosd`

PR-URL: https://github.com/stdlib-js/stdlib/pull/5837

Co-authored-by: Gunj Joshi <[email protected]>
Co-authored-by: Karan Anand <[email protected]>
Co-authored-by: Karan Anand <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Gunj Joshi <[email protected]>
Signed-off-by: Gunj Joshi <[email protected]>

Please review the above commit message and make any necessary adjustments.

anandkaranubc added 4 commits March 6, 2025 14:48

stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Mar 7, 2025

gunjjoshi requested changes Mar 7, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/sincosd/README.md Outdated Show resolved Hide resolved

anandkaranubc commented Mar 7, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/sincosd/lib/main.js Show resolved Hide resolved

anandkaranubc and others added 2 commits March 6, 2025 23:05

Merge branch 'stdlib-js:develop' into feat/sincosd

1279aae

anandkaranubc requested a review from gunjjoshi March 7, 2025 07:28

gunjjoshi reviewed Mar 7, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/sincosd/src/main.c Show resolved Hide resolved

gunjjoshi reviewed Mar 7, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/sincosd/README.md Outdated Show resolved Hide resolved

anandkaranubc added 2 commits March 7, 2025 10:56

gunjjoshi reviewed Mar 7, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/sincosd/README.md Outdated Show resolved Hide resolved

Apply suggestions from code review

0899e1a

Signed-off-by: Gunj Joshi <[email protected]>

gunjjoshi reviewed Mar 7, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/sincosd/docs/repl.txt Outdated Show resolved Hide resolved

Update lib/node_modules/@stdlib/math/base/special/sincosd/docs/repl.txt

2fc1994

Signed-off-by: Gunj Joshi <[email protected]>

gunjjoshi approved these changes Mar 7, 2025

View reviewed changes

Planeshifter approved these changes Mar 7, 2025

View reviewed changes

Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 7, 2025

stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 7, 2025

Planeshifter merged commit 6d7317a into stdlib-js:develop Mar 7, 2025
29 checks passed

anandkaranubc deleted the feat/sincosd branch May 10, 2025 14:33

	{{alias}}( x, out, stride, offset )
	{{alias}}.assign( x, out, stride, offset )

	* var v = sincosd( out, 0.0 );
	* var v = sincosd.assign( 0.0, out, 1, 0 );

	t.equal( isnan( v[0] ), true, 'returns NaN' );
	t.equal( isnan( v[0] ), true, 'returns expected value' );

	"description": "Simultaneously compute the sine and cosine an angle measured in degrees.",
	"description": "Simultaneously compute the sine and cosine of an angle measured in degrees.",


		# sincosd

		> Simultaneously compute the [sine][@stdlib/math/base/special/sind] and [cosine][@stdlib/math/base/special/cosd] an angle measured in degrees.


		#### sincosd( x )

		Simultaneously computes the [sine][@stdlib/math/base/special/sind] and [cosine][@stdlib/math/base/special/cosd] of a `number` (in degrees).


		#### sincosd.assign( x, out, stride, offset )

		Simultaneously computes the [sine][@stdlib/math/base/special/sind] and [cosine][@stdlib/math/base/special/cosd] of a `number` (in degrees) and assigns results to a provided output array.


		#### stdlib_base_sincosd( x, &sine, &cosine )

		Simultaneously computes the [sine][@stdlib/math/base/special/sind] and [cosine][@stdlib/math/base/special/cosd] of a `number` (in degrees).

Uh oh!

feat: add math/base/special/sincosd #5837

feat: add math/base/special/sincosd #5837

Uh oh!

Conversation

anandkaranubc commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Questions

Other

Checklist

Uh oh!

anandkaranubc commented Mar 7, 2025

Uh oh!

stdlib-bot commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

anandkaranubc commented Mar 7, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gunjjoshi commented Mar 7, 2025

Uh oh!

anandkaranubc commented Mar 7, 2025

Uh oh!

stdlib-bot commented Mar 7, 2025

PR Commit Message

Uh oh!

Uh oh!

Uh oh!

feat: add `math/base/special/sincosd` #5837

feat: add `math/base/special/sincosd` #5837

anandkaranubc commented Mar 7, 2025 •

edited

Loading

stdlib-bot commented Mar 7, 2025 •

edited

Loading