-
-
Notifications
You must be signed in to change notification settings - Fork 804
bench: refactor random number generation in stats/base/dists/levy
#6044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hemantmm <[email protected]>
Signed-off-by: hemantmm <[email protected]>
Coverage Report
The above coverage report was generated for the changes in this PR. |
Signed-off-by: hemantmm <[email protected]>
Signed-off-by: hemantmm <[email protected]>
@anandkaranubc have a look at the PR. |
@anandkaranubc any update? |
kgryte
reviewed
Mar 22, 2025
lib/node_modules/@stdlib/stats/base/dists/levy/ctor/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 22, 2025
lib/node_modules/@stdlib/stats/base/dists/levy/ctor/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 22, 2025
lib/node_modules/@stdlib/stats/base/dists/levy/ctor/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 22, 2025
lib/node_modules/@stdlib/stats/base/dists/levy/ctor/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
kgryte
reviewed
Mar 22, 2025
lib/node_modules/@stdlib/stats/base/dists/levy/entropy/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 22, 2025
lib/node_modules/@stdlib/stats/base/dists/levy/logpdf/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 22, 2025
lib/node_modules/@stdlib/stats/base/dists/levy/mean/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 22, 2025
lib/node_modules/@stdlib/stats/base/dists/levy/mean/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
…ian/benchmark/benchmark.js
…ian/benchmark/benchmark.native.js
kgryte
reviewed
Mar 22, 2025
lib/node_modules/@stdlib/stats/base/dists/levy/mode/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 22, 2025
lib/node_modules/@stdlib/stats/base/dists/levy/mode/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 22, 2025
lib/node_modules/@stdlib/stats/base/dists/levy/mode/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 22, 2025
lib/node_modules/@stdlib/stats/base/dists/levy/pdf/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 22, 2025
lib/node_modules/@stdlib/stats/base/dists/levy/pdf/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
…ntile/benchmark/benchmark.js
…ntile/benchmark/benchmark.native.js
kgryte
reviewed
Mar 22, 2025
lib/node_modules/@stdlib/stats/base/dists/levy/stdev/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 22, 2025
lib/node_modules/@stdlib/stats/base/dists/levy/stdev/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 22, 2025
lib/node_modules/@stdlib/stats/base/dists/levy/variance/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 22, 2025
lib/node_modules/@stdlib/stats/base/dists/levy/variance/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
kgryte
approved these changes
Mar 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after clean-up.
1 task
Girish-Garg
pushed a commit
to Girish-Garg/stdlib
that referenced
this pull request
Mar 23, 2025
PR-URL: stdlib-js#6044 Closes: stdlib-js#4977 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: hemantmm <[email protected]> Signed-off-by: Athan Reines <[email protected]>
sahil20021008
pushed a commit
to sahil20021008/stdlib
that referenced
this pull request
Mar 26, 2025
PR-URL: stdlib-js#6044 Closes: stdlib-js#4977 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: hemantmm <[email protected]> Signed-off-by: Athan Reines <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Benchmarks
Pull requests adding or improving benchmarks for measuring performance.
Good First PR
A pull request resolving a Good First Issue.
Statistics
Issue or pull request related to statistical functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4977
Description
This pull request:
Related Issues
This pull request:
stats/base/dists/levy
#4977Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers