Skip to content

test: add tests for IEEE 754-2019 compliance #6557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2025
Merged

test: add tests for IEEE 754-2019 compliance #6557

merged 2 commits into from
Apr 5, 2025

Conversation

anandkaranubc
Copy link
Contributor

Progresses #365

Description

What is the purpose of this pull request?

This pull request:

  • Add positive and negative zero tests for IEEE 754-2019 compliance in the remaining math/base/special/* packages

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@anandkaranubc
test: add tests for IEEE 754-2019 compliance
cc8dd2c 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Apr 5, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Apr 5, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/base/special/asin $\color{red}361/373$
$\color{green}+96.78\%$ 		$\color{red}27/32$
$\color{green}+84.38\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{red}361/373$
$\color{green}+96.78\%$
math/base/special/sinpi $\color{green}210/210$
$\color{green}+100.00\%$ 		$\color{green}20/20$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}210/210$
$\color{green}+100.00\%$
math/base/special/tan $\color{green}229/229$
$\color{green}+100.00\%$ 		$\color{green}11/11$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}229/229$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@anandkaranubc
Copy link
Contributor Author

With this, all the highlighted ones should be done.

image

To my understanding, the non-highlighted ones are not implemented yet.

@kgryte kgryte added the Tests Pull requests specifically adding tests. label Apr 5, 2025
@kgryte
Copy link
Member

kgryte commented Apr 5, 2025

@anandkaranubc Would you mind resolving the merge conflicts here?

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Apr 5, 2025
@anandkaranubc
Copy link
Contributor Author

@anandkaranubc Would you mind resolving the merge conflicts here?

Resolved :)

Planeshifter
Planeshifter approved these changes Apr 5, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Apr 5, 2025
@stdlib-bot stdlib-bot removed the Needs Changes Pull request which needs changes before being merged. label Apr 5, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

test: add tests for IEEE 754-2019 compliance

PR-URL: https://github.com/stdlib-js/stdlib/pull/6557
Ref: https://github.com/stdlib-js/stdlib/issues/365

Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Karan Anand <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit d9ad02c into stdlib-js:develop Apr 5, 2025
28 checks passed
@anandkaranubc anandkaranubc deleted the ieee/zero branch April 7, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged. Tests Pull requests specifically adding tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anandkaranubc @stdlib-bot @kgryte @Planeshifter