-
-
Notifications
You must be signed in to change notification settings - Fork 831
test: change structure of fixtures for blas/base/dtrmv
#7190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
"N": 3, | ||
"A": [ 1.0, 2.0, 3.0, 0.0, 4.0, 5.0, 0.0, 0.0, 6.0 ], | ||
"A_mat": [ | ||
[ 1.0, 2.0, 3.0 ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShabiShett07 Correct me if I am wrong, but shouldn't A_mat
be lower triangular per L3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason why A_mat
is in an upper triangular matrix, it us column major, so the elements are accesses in column-wise that means it should be written the form of row-major upper
that was my thought related to this. Also you can see that A
is written in the same way here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whether it is stored in row-major or column-major is not material, as A_mat
should be from the perspective of the end-user. An array order is a storage layout, which should not be apparent to users. That means, if A
is supposed to be lower triangular, A_mat
should be lower triangular.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If A
is column-major and not transposed, that means that data is stored column-wise. In which case,
A_mat = [
[ 1.0, 0.0, 0.0 ],
[ 2.0, 4.0, 0.0 ],
[ 3.0, 5.0, 6.0 ]
]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I will make the necessary changes
"N": 3, | ||
"A": [ 6.0, 999.0, 0.0, 999.0, 0.0, 5.0, 999.0, 4.0, 999.0, 0.0, 3.0, 999.0, 2.0, 999.0, 1.0 ], | ||
"A_mat": [ | ||
[ 1.0, 2.0, 3.0 ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment. Lower triangular?
"N": 3, | ||
"A": [ 1.0, 2.0, 3.0, 0.0, 4.0, 5.0, 0.0, 0.0, 6.0 ], | ||
"A_mat": [ | ||
[ 1.0, 2.0, 3.0 ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShabiShett07 I suggest revisiting these and ensuring that A_mat
correctly reflects uplo
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left initial comments.
Signed-off-by: Shabareesh Shetty <[email protected]>
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
none
Description
This pull request:
A_mat
for user reference matrixRelated Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers