Fix invalid array index validation to reject indices with leading zeros #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The current regex pattern used to validate array indices in the
jsonpointer
package incorrectly accepts indices with leading zeros (such as "01", "00", "0123"), which violates the JSON Pointer specification (RFC 6901).Root Cause
The current regex pattern has a logical flaw:
This pattern:
0|[1-9][0-9]*$
)^
)Fix
Updated the regex pattern to properly validate array indices according to RFC 6901:
This fix:
^
(?:...)
for efficiencyAdded Tests
Added tests to verify that invalid array indices with leading zeros are properly rejected:
All tests pass, confirming that the fix works correctly and doesn't break existing functionality.
Fixes #63.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.