Skip to content

Commit 066dd03

Browse files
authored
Merge pull request kubernetes-sigs#4 from DirectXMan12/refactor/update-deps-and-rename
Update Dependencies and Rename
2 parents daee026 + 778fad9 commit 066dd03

File tree

15 files changed

+189
-308
lines changed

15 files changed

+189
-308
lines changed

.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
*.swp
22
*~
33
sample-main
4+
vendor

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ implementation backed by fake data.
1212
## How to use this repository
1313

1414
In order to use this repository, you should vendor this repository at
15-
`k8s.io/custom-metrics-boilerplate`, and implement the
16-
`"k8s.io/custom-metrics-boilerplate/pkg/provider".CustomMetricsProvider`
15+
`github.com/directxman12/custom-metrics-boilerplate`, and implement the
16+
`"github.com/directxman12/custom-metrics-boilerplate/pkg/provider".CustomMetricsProvider`
1717
interface. You can then pass this to the main setup functions.
1818

1919
The `pkg/cmd` package contains the building blocks of the actual API

glide.lock

+101-20
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

glide.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package: k8s.io/custom-metrics-boilerplate
1+
package: github.com/directxman12/custom-metrics-boilerplate
22
import:
33
- package: github.com/emicklei/go-restful
44
- package: github.com/spf13/cobra

pkg/apiserver/apiserver.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import (
2626
"k8s.io/apimachinery/pkg/version"
2727
genericapiserver "k8s.io/apiserver/pkg/server"
2828

29-
"k8s.io/custom-metrics-boilerplate/pkg/provider"
29+
"github.com/directxman12/custom-metrics-boilerplate/pkg/provider"
3030
"k8s.io/metrics/pkg/apis/custom_metrics/install"
3131
)
3232

@@ -88,7 +88,7 @@ func (c *Config) SkipComplete() completedConfig {
8888

8989
// New returns a new instance of CustomMetricsAdapterServer from the given config.
9090
func (c completedConfig) New(cmProvider provider.CustomMetricsProvider) (*CustomMetricsAdapterServer, error) {
91-
genericServer, err := c.Config.GenericConfig.SkipComplete().New() // completion is done in Complete, no need for a second time
91+
genericServer, err := c.Config.GenericConfig.SkipComplete().New(genericapiserver.EmptyDelegate) // completion is done in Complete, no need for a second time
9292
if err != nil {
9393
return nil, err
9494
}

pkg/apiserver/cmapis.go

+8-7
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,11 @@ import (
2323
"k8s.io/apimachinery/pkg/runtime/schema"
2424
genericapi "k8s.io/apiserver/pkg/endpoints"
2525
genericapiserver "k8s.io/apiserver/pkg/server"
26+
"k8s.io/apiserver/pkg/endpoints/discovery"
2627

27-
specificapi "k8s.io/custom-metrics-boilerplate/pkg/apiserver/installer"
28-
"k8s.io/custom-metrics-boilerplate/pkg/provider"
29-
metricstorage "k8s.io/custom-metrics-boilerplate/pkg/registry/custom_metrics"
28+
specificapi "github.com/directxman12/custom-metrics-boilerplate/pkg/apiserver/installer"
29+
"github.com/directxman12/custom-metrics-boilerplate/pkg/provider"
30+
metricstorage "github.com/directxman12/custom-metrics-boilerplate/pkg/registry/custom_metrics"
3031
"k8s.io/metrics/pkg/apis/custom_metrics"
3132
)
3233

@@ -43,19 +44,19 @@ func (s *CustomMetricsAdapterServer) InstallCustomMetricsAPI() error {
4344
Version: groupMeta.GroupVersion.Version,
4445
}
4546
apiGroup := metav1.APIGroup{
46-
Name: groupMeta.GroupVersion.String(),
47+
Name: groupMeta.GroupVersion.Group,
4748
Versions: []metav1.GroupVersionForDiscovery{groupVersion},
4849
PreferredVersion: preferredVersionForDiscovery,
4950
}
5051

5152
cmAPI := s.cmAPI(groupMeta, &groupMeta.GroupVersion)
5253

53-
if err := cmAPI.InstallREST(s.GenericAPIServer.HandlerContainer.Container); err != nil {
54+
if err := cmAPI.InstallREST(s.GenericAPIServer.Handler.GoRestfulContainer); err != nil {
5455
return err
5556
}
5657

57-
path := genericapiserver.APIGroupPrefix + "/" + groupMeta.GroupVersion.Group
58-
s.GenericAPIServer.HandlerContainer.Add(genericapi.NewGroupWebService(s.GenericAPIServer.Serializer, path, apiGroup))
58+
s.GenericAPIServer.DiscoveryGroupManager.AddGroup(apiGroup)
59+
s.GenericAPIServer.Handler.GoRestfulContainer.Add(discovery.NewAPIGroupHandler(s.GenericAPIServer.Serializer, apiGroup).WebService())
5960

6061
return nil
6162
}

pkg/apiserver/installer/apiserver_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ import (
4040
"k8s.io/metrics/pkg/apis/custom_metrics"
4141
cmv1alpha1 "k8s.io/metrics/pkg/apis/custom_metrics/v1alpha1"
4242

43-
"k8s.io/custom-metrics-boilerplate/pkg/provider"
44-
metricstorage "k8s.io/custom-metrics-boilerplate/pkg/registry/custom_metrics"
43+
"github.com/directxman12/custom-metrics-boilerplate/pkg/provider"
44+
metricstorage "github.com/directxman12/custom-metrics-boilerplate/pkg/registry/custom_metrics"
4545

4646
)
4747

0 commit comments

Comments
 (0)