Sync Fork from Upstream Repo #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously -n12 provided fast builds, but it looks like -n2 is marginally faster now. Total runtime went from 1 hr 48 min to 1 hr 41 min (though with a sample size of 1).
Previously we ran them both compiled and interpreted, which seems redundant.
I've seen this speed up `runtests.py` by about 20s when multiple cores are available.
Previously various slow tests were included with fast tests, resulting in non-optimal parallelization.
Relates to #7633. * testDisallowAnyUnimported is checked in testDisallowImplicitAnyVariableDefinition from check-flags.test so I removed it from cmdline.test instead of porting it. * most tests are moved from cmdline.test to check-flags.test * two remaining: testDisallowAnyGenericsBuiltinCollections and testDisallowAnyGenericsTypingCollections due to no fixture for fronzenset avaliable
Python 3.5.1 tests were the slowest job, and this makes them faster (roughly from 20min to 15min).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.