Skip to content

Staged pac #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Apr 28, 2025
Merged

Staged pac #167

merged 39 commits into from
Apr 28, 2025

Conversation

usbalbin
Copy link
Member

No description provided.

usbalbin and others added 30 commits November 8, 2024 20:58
@usbalbin
Use latest pac
bf01572
@usbalbin
Update DMA for new pac
0a0edec
@usbalbin
Update for new pac
3f00ac9
@usbalbin
Fix clippy warnings
d533228
@usbalbin
fmt
d594db4
@usbalbin
Add G91 and G4A1 to CI
aa1a7a3
@usbalbin
Add support for G491 and G4A1
4886998
@usbalbin
rename device feature
5de0c65
@usbalbin
Update for new pac with write and modify not returning unit type
41fb3c2
@usbalbin
Update for new pac with write and modify not returning unit type - fo…
c92be81 
…r G431 and friends
@usbalbin
Fix some leftover G491 things
6e23b8d
@usbalbin
g491 and g4a1 does not have ADC4 and 5
bfc82e2
@usbalbin @burrbull
Update src/fdcan.rs
de17e3e 
Co-authored-by: Zgarbul Andrey <[email protected]>
@usbalbin
Slightly demacrofy DMA
145ba50
@AdinAck @usbalbin
Update cordic.rs
ad40976
@AdinAck @usbalbin
fix annoying clippy lint
9772644
@AdinAck @usbalbin
Update ci.yml
9c2e5ff
@AdinAck @usbalbin
fix cordic example
c8cfbba
@AdinAck @usbalbin
update ci to include logging for cordic
1a98a67
@AdinAck @usbalbin
override clippy empty loop
46d44d8
@usbalbin
Merge remote-tracking branch 'upstream/main' into update_for_main_cha…
efc5913 
…nges
@usbalbin
fmt
3e78aef
@usbalbin
Fix clippy
9f3c8f2
@usbalbin
Merge pull request #152 from usbalbin/update_for_main_changes
13f2b09 
merge updates from main
@usbalbin
Bump pac (#149)
c9f612f
@usbalbin
DMA - rename stream to channel (#147)
87bd6f0 
* DMA - Rename stream to channel

* DMA - Make ChannelsTuple a struct
@usbalbin
Add hrtim to rcc (#154)
899c279
@usbalbin
Constify rcc config (#161)
0e8cb64
@usbalbin @AdinAck
Merge from main (#166)
d0a011f 
* Export pac as pac (#156)

* rm remaining fdcan files (#160)

* defmt format for rcc clocks (#163)

---------

Co-authored-by: AdinAck <[email protected]>
@usbalbin
Simplify DMA impl removing most macros (#162)
e8ac42d 
* Simplify DMA impl removing most macros

* Clippy
@usbalbin
Merge remote-tracking branch 'upstream/main' into merge_from_main2
a4adc70
@usbalbin
Merge pull request #176 from usbalbin/merge_from_main2
e3e22ab 
Merge from main
@usbalbin
Cleanup gpio (#177)
7a4962c
@usbalbin
Merge remote-tracking branch 'upstream/main' into staged-pac
c8a8d7f
@usbalbin
Update for new pac (#183)
b08673e 
* Changes from stm32g4-staging v0.19 to stm32-rs#1156

* Follow @burrbull suggestion

* Use `clear` methods to clear interrupt flags

* Bump pac

* fmt

* Fix i2c

* Fix new clippy issues
@usbalbin
Copy link
Member Author

@AdinAck , @burrbull , @liamkinne do you see any reason to keep the separate branch with the changes for the new pac, or should we just merge this?

@AdinAck
Copy link
Contributor

AdinAck commented Mar 23, 2025

The only constraint on my end is that cordic relies on from_modify, which was previously only in the staged PAC. If that has been merged into the normal PAC then it should be fine!

@usbalbin
Copy link
Member Author

As far as I know the normal PAC still has not released any new versions since about 2 years ago. I do not know the story there, but @burrbull has been very quick with releasing new versions of staging PAC when new features have been merged. (thanks a lot)

Since the last "normal PAC"-release there has been a whole lot of bug fixes, lots of deduplications of types, arrayification of fields, making more things safe, and your from_modify (and probably a whole lot of more things that I do not understand) etc that all in all allow a lot of nice cleanup in the hal.

I made the staged-pac-branch in this hal to target the "staging PAC" releases of the pac so we can start using all the new improvements. At this point the regular master branch is starting to get outdated with issues popping up like #184 and I believe more that I have forgotten which are solved in staged-pac.

So, in short, any reason to not just merge this staged-pac-branch into master and thus have master depend on staging PAC-releases of the pac?

@burrbull
Copy link
Member

The story is simple. @adamgreig is busy all time. Let's ask him on next meeting. Maybe something has been changed.

@usbalbin
Copy link
Member Author

The story is simple. @adamgreig is busy all time. [...]

I understand, and that is fine :) (Also let me know if there is anything I can help with)

Let's ask him on next meeting. Maybe something has been changed.

No rush on my account :). I see stm32f4xx-hal is using the staging-pac do you think we should merge this? (I am also more than happy to wait)

@burrbull
Copy link
Member

No rush on my account :). I see stm32f4xx-hal is using the staging-pac do you think we should merge this? (I am also more than happy to wait)

Yes, I use staging branch in f4xx-hal during a year. So you know my position.

usbalbin and others added 4 commits April 26, 2025 20:58
@usbalbin
clippy (#191)
0ac9098 
* clippy
@usbalbin
stm32g4-staging v0.22.0 (#190)
49632de
@burrbull
DAC unmacro (#189)
8df6635
@usbalbin
Add Tests (#179)
1990e99 
* Add pwm test

* Remove log-rtt

* Not working...

* Add more tests

* Rename things

* Add more tests

* Fix DAC test

* fmt
@burrbull
Copy link
Member

Good time to merge in the main :)

@usbalbin usbalbin marked this pull request as ready for review April 28, 2025 19:06
@usbalbin
Copy link
Member Author

I agree :)

@usbalbin usbalbin merged commit f95f10e into main Apr 28, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@usbalbin @AdinAck @burrbull