Skip to content

Fix compiler warnings #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fpistm opened this issue Jun 29, 2017 · 0 comments
Closed

Fix compiler warnings #44

fpistm opened this issue Jun 29, 2017 · 0 comments
Assignees
@fpistm
Labels
bug 🐛 Something isn't working
Milestone
2017.8.31

Comments

@fpistm
Copy link
Member

fpistm commented Jun 29, 2017

Enabling compiler warning to "All" in Arduino IDE preferences show several warnings.
@fpistm fpistm self-assigned this Jun 29, 2017
@fpistm fpistm added this to the next release milestone Jun 29, 2017
@fpistm fpistm added the bug 🐛 Something isn't working label Jun 29, 2017
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Jun 29, 2017
@fpistm
Fix compiler warning: "UNUSED" redefined
2e3c60b 
Fix stm32duino#44
cores/arduino/syscalls_stm32.c:45:0: warning: "UNUSED" redefined
 #define UNUSED(x) x ## _UNUSED __attribute__((__unused__))

Signed-off-by: Frederic.Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Jun 29, 2017
@fpistm
Fix compiler warning: comparison between pointer and integer
a7ffd7b 
Fix stm32duino#44
cores/arduino/WInterrupts.c:30:12: warning: comparison between pointer and integer
   if (port == NC)

Signed-off-by: Frederic.Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Jun 29, 2017
@fpistm
Fix compiler warning: implicit declaration of function
21066ce 
Fix stm32duino#44
cores/arduino/wiring_digital.c:37:8: warning: implicit declaration of function 'is_pin_configured' [-Wimplicit-function-declaration]
     if(is_pin_configured(p, g_anOutputPinConfigured)) {

Signed-off-by: Frederic.Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Jun 29, 2017
@fpistm
Fix compiler warning: 'uwTimclock' may be used uninitialized
b696486 
Fix stm32duino#44
cores/arduino/stm32/timer.c:733:19: warning: 'uwTimclock' may be used uninitialized in this function [-Wmaybe-uninitialized]
         uwTimclock*=2;

Signed-off-by: Frederic.Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Jun 29, 2017
@fpistm
Fix compiler warning: control reaches end of non-void function
4f8a1b2 
Fix stm32duino#44
cores/arduino/wiring_digital.c:90:1: warning: control reaches end of non-void function [-Wreturn-type]
 }

Signed-off-by: Frederic.Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Jun 29, 2017
@fpistm
Fix compiler warning: unused parameter [-Wunused-parameter]
44f6cf2 
Fix stm32duino#44

Signed-off-by: Frederic.Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Jun 29, 2017
@fpistm
dtostrf: use width argument
c8c6e43 
Fix stm32duino#44
Handle minimum field width of the output string
width is signed value, negative for left adjustment.
Range -128,127

Signed-off-by: Frederic.Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Jun 29, 2017
@fpistm
Fix compiler warning: differ in signedness
bc76435 
Fix stm32duino#44
syscalls_stm32.c:118:20: warning: pointer targets in passing argument 1 of 'uart_debug_write' differ in signedness [-Wpointer-sign]
   uart_debug_write(ptr, len);

Signed-off-by: Frederic.Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Jun 29, 2017
@fpistm
Fix compiler warning: 'return' with a value
06d8d46 
Fix stm32duino#44
cores/arduino/stm32/analog.c:723:40: warning: 'return' with a value, in function returning void
   if (timHandle.Instance == NC) return 0;

Signed-off-by: Frederic.Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Jun 29, 2017
@fpistm
Fix compiler warning: assignment makes pointer from integer without a…
c62250c 
… cast

Fix stm32duino#44
cores/arduino/stm32/PortNames.c:38:22: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
             gpioPort = GPIOA_BASE;

Signed-off-by: Frederic.Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Jun 29, 2017
@fpistm
Fix compiler warning: initialization makes integer from pointer witho…
2fbfed0 
…ut a cast

Fix stm32duino#44
Using a uint32_t was a legacy from mbed pinmap feature.
This allow to be compatible with high leve api common to all mbed target.
There is not reason to keep it for Arduino.
Peripheral(SPIx, DACx, TIMx,...) is a pointer so manage it as it is to avoid
cast.

system/Drivers/CMSIS/Device/ST/STM32F4xx/Include/stm32f429xx.h:1245:29: warning: initialization makes integer from pointer without a cast [-Wint-conversion]
 #define ADC1                ((ADC_TypeDef *) ADC1_BASE)

                              ^
/local/data/work/stm32/stm32duino/arduino-1.8.3/hardware/STM32/stm32/variants/NUCLEO_F429ZI/PeripheralPins.c:41:13: note: in expansion of macro 'ADC1'
     {PA0,   ADC1,  STM_PIN_DATA_EXT(STM_MODE_ANALOG, GPIO_NOPULL, 0, 0, 0)}, // ADC1_IN0 - PA0/WKUP
             ^~~~
...

Signed-off-by: Frederic.Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Jun 29, 2017
@fpistm
Fix compiler warning in Wire library
70c2a85 
Fix stm32duino#44

Signed-off-by: Frederic.Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Jun 29, 2017
@fpistm
Fix compiler warning in Firmata library
3b5cf9d 
Fix stm32duino#44

Signed-off-by: Frederic.Pillon <[email protected]>
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Jun 29, 2017
@fpistm
Fix last compiler warning
b37099d 
Fix stm32duino#44

Signed-off-by: Frederic.Pillon <[email protected]>
@fpistm fpistm closed this as completed in 3f6c7c7 Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fpistm fpistm

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
2017.8.31
Development

No branches or pull requests
1 participant
@fpistm