refactor: Improve reliability and simplify implementation #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABOSTM
force-pushed
the
RTC_PREVENT_1S_LOSE
branch
from
5a25365 to
b2f6c10
Compare
* call HAL_RTC_Init() only when needed to avoid losing hundreds of milliseconds on RTC counter * remove useless check of _configured at the beginning of STM32RTC class methods * Use flag "INITS" to detect whether RTC calendar is initialized (except for F1 which doesn't have this flag) This prevent the use of year 2000 which is the default hardware reset value and doesn't trigger INITS flag * Use Backup registers only for F1, and no more for other series * Simplify class state management: - remove _configured and _reset, _alarmEnabled - add _timeSet fixes stm32duino#66 Signed-off-by: Alexandre Bourdiol <[email protected]>
ABOSTM
force-pushed
the
RTC_PREVENT_1S_LOSE
branch
from
b2f6c10 to
cda850c
Compare
fpistm
approved these changes
Jun 6, 2022
This was referenced Sep 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: Improve reliability and simplify implementation
of milliseconds on RTC counter
STM32RTC class methods
(except for F1 which doesn't have this flag)
This prevent the use of year 2000 which is the default hardware
reset value and doesn't trigger INITS flag
Tested on BluePill and Nucleo L476RG, with examples from STM32duino_RTC library
fixes #66